On 2.8.2016 17:12, Rob Crittenden wrote: > Pavel Vomacka wrote: >> Hello, >> >> please review attached patches which Split make lint to more targets and >> add jslint > > What's the driver to split the checks out into separate targets?
Most importantly, makeapi and makeaci do not need to be called 10 times during single build (and can be called in parallel, once our build system can manage that). > You are moving the makeapi and makeaci from version-update to lint. They were > in version-update for a reason: downstream builds do not call lint. Downstream > may patch code. API cannot break. This is very true, I definitely agree. Even better, downstream should call as much checks as possible. This split allows the downstream spec to call all tools which are available in downstream as part of %check section of the spec, which was not possible before the split. > No ticket? -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
