Hello,

this is the last patch necessary to get all test_xmlrpc/test_dns_plugin tests
to pass! (I hope :-)

    Tests: fix test_forward_zones in test_xmlrpc/test_dns_plugin

    Class test_forward_zones in ipatests/test_xmlrpc/test_dns_plugin
    was using DNS zone 'fwzone2.test.' and expected to get warning
    'Forwarding policy conflicts with some automatic empty zones.'
    (aka 'DNSForwardPolicyConflictWithEmptyZone').

    This does not make sense because 'test.' zone is not listed in IANA registry
    'Locally-Served DNS Zones':

http://www.iana.org/assignments/locally-served-dns-zones/locally-served-dns-zones.xhtml

    To fix this I simply removed the warning from set of expected results.

    https://fedorahosted.org/freeipa/ticket/6213


-- 
Petr^2 Spacek
From 663178e3f305d25cd9ad53bbb85b80a89181b5b9 Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Fri, 12 Aug 2016 19:49:33 +0200
Subject: [PATCH] Tests: fix test_forward_zones in test_xmlrpc/test_dns_plugin

Class test_forward_zones in ipatests/test_xmlrpc/test_dns_plugin
was using DNS zone 'fwzone2.test.' and expected to get warning
'Forwarding policy conflicts with some automatic empty zones.'
(aka 'DNSForwardPolicyConflictWithEmptyZone').

This does not make sense because 'test.' zone is not listed in IANA registry
'Locally-Served DNS Zones':
http://www.iana.org/assignments/locally-served-dns-zones/locally-served-dns-zones.xhtml

To fix this I simply removed the warning from set of expected results.

https://fedorahosted.org/freeipa/ticket/6213
---
 ipatests/test_xmlrpc/test_dns_plugin.py | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index aa011ceba69285b0149c60f87b1df4b0e0f3de9e..196aa0c39002050229209669cfc528574cc9ab26 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -3444,15 +3444,7 @@ class test_forward_zones(Declarative):
             expected={
                 'value': fwzone2_dnsname,
                 'summary': None,
-                u'messages': (
-                    {u'message': lambda x: x.startswith(
-                        u"Forwarding policy conflicts with some "
-                        "automatic empty zones."),
-                     u'code': 13021,
-                     u'type': u'warning',
-                     u'name': u'DNSForwardPolicyConflictWithEmptyZone',
-                     u'data': {}},
-                    {u'message': lambda x: x.startswith(
+                u'messages': ({u'message': lambda x: x.startswith(
                         u"DNS server %s: query '%s SOA':" %
                         (forwarder1, fwzone2)),
                      u'code': 13006,
-- 
2.7.4

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to