URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional

lslebodn commented:
On (01/03/17 22:37), Jan Cholasta wrote:
>I tend to agree with @lslebodn, but I don't have a strong opinion on this. I 
>noticed a couple of issues though:
>* `--without-jslint` does not seem to work correctly:
>  ```
>  $ ./configure --without-jslint
>  ...
>                      IPA Server 4.4.90.dev201703020634+git3a29b47
>                      ========================
>  ...
>          jslint:                   /usr/bin/jsl
>  ...
>  ```
>* In `freeipa.spec.in`, when `with_lint` is not defined, lint should be 
>disabled, so `--disable-pylint` and `--without-jslint` should be passed to 

This is exactly a reason why the simplest solution would be
to exend error messages without changing default.

Default "yes" should encourage downstream packagers[1,2] to run
make lint and catch issues with backported(downstream only) patches.

BTW there were also some version of packages for opensuse[2]
but they were removed.

[1] https://anonscm.debian.org/cgit/pkg-freeipa/freeipa.git
[2] https://en.opensuse.org/Portal:FreeIPA


See the full comment at 
Manage your subscription for the Freeipa-devel mailing list:
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to