I found that when running FreeIPA Web UI on IE10 that modal dialogs close
when enter is pressed. Normal functionality is to 'submit' the dialog on an
enter keypress.

I found a solution by adding a type="button" attribute to the close button
of the dialog (in /install/ui/src/freeipa/dialog.js).

I have tested on recent Chrome, IE and Firefox versions as well as on IE10.
Seems to be no side-effects.

Attached is a patch showing the change I made. Apologies if the patch isn't
formatted correctly.


Jim G
From 53503f6cb28c1923a841cc837b8f1e062b2d429b Mon Sep 17 00:00:00 2001
From: James Groffen <jim.grof...@gmail.com>
Date: Thu, 7 Jan 2016 14:26:03 +1030
Subject: [PATCH] Set close button type attribute to 'button'.

Stops IE10 from closing the dialog on an enter keypress.

 install/ui/src/freeipa/dialog.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/install/ui/src/freeipa/dialog.js b/install/ui/src/freeipa/dialog.js
index 22bda3e..4c157c5 100644
--- a/install/ui/src/freeipa/dialog.js
+++ b/install/ui/src/freeipa/dialog.js
@@ -395,6 +395,7 @@ IPA.dialog = function(spec) {
         that.title_close_button = $('<button/>', {
             'class': 'close',
+            'type': 'button',
             'aria-hidden': 'true',
             click: function() {

Manage your subscription for the Freeipa-users mailing list:
Go to http://freeipa.org for more info on the project

Reply via email to