On 08/17/10 20:04, Albert Chu:
I'll tweak a few formatting things to be consistent to other parts of FreeIPMI, and I think I'll do 
"first" and "last" instead of "0"
or "-1" for the first/last SEL entry.

You are welcome.

But I'm a tad confused on this in your printf at the end:

data_len == text_len ? "" : " ... (text incomplete)");

Is there some subtlety of the get-sel-long-text OEM command that isn't
clear to me

Total size of message related to a SEL may be larger than specified MaxResponseDataSize (MaxResponseDataSize can't exceed 100 on my system or the call will fail).

The "data length" field in response contain length of complete message (not the part returned just now). If you received incomplete message (e.g. actual length is less than claimed data length) then you can call function again, with non-zero Offset field in request, to obtain the rest of message.

I didn't implemented repeated call so the text "incomplete" instead of it.

                                        Dan




_______________________________________________
Freeipmi-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/freeipmi-devel

Reply via email to