Simon <[EMAIL PROTECTED]> wrote:
> Blah, radrelay was infact segfaulting on any A/V pair that
> valuepair.c:userparse was having trouble with due to a stupid bug on my
> part. Tiny patch included below to fix this.
Added, thanks.
> Now radrelay will silently ignore any cruft that may have ended up in
> the detail file for some reason, which is good.
> The bad part is that attributes which don't have a dictionary entry when
> they're added to the detail file (eg. Attr-X = "stuff" mentioned above)
> will also be ignored since userparse doesn't seem to like those.
Yes, that's a minor problem. We can probably hack pairmake() to
check for those, and create attributes by hand. The problem with that
is you don't know what type they are, so maybe they should all be set
to 'octets'.
> Is there any easy way included in lib/* to deal with those?
It should be fixed in pairmake(). Something like:
if found in dictionary
do stuff it does now to make the VP
else
create VP
vp->attribute = atoi()
vp->name = strcopy ATTR-nn
vp->type = octets
...
Alan DeKok.
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html