Paul Hampson wrote: > > > The following patch allow for SQL logging after authentication. It > > > extends the rlm_sql module so now you can put one more query in your > > > sql.conf file. > > > > I'll commit this once either you tell me that it doesn't depend on > > Post-Auth-Type, or I commit the Post-Auth-Type patch. (Which I'm > > going to look at now.)
Well, the patch will apply without a problem but it is much less interesting because you can query the db only if the authentication step is successful. For the hotline service for example (ie the bad guys who made me write this patch ^_^) it is much more useful to gather information about failed attempts. > > With one minor change, to call > > (inst->module->sql_finish_query)(sqlsocket, inst->config); > > even for failed queries. (As is done in _some_ of the other sql_ > > function in rlm_sql.c. And PostgresSQL's docs also do it... Only > > postgres and Sybase (off hand, Oracle too maybe) actually implement > > the function anyway. I don't understand. There is a return RLM_MODULE_FAIL just above, so sql_finish_query() is not called on failed query. > Bugger. That patch got boned as well. Can you either attach it to an > email for me, or put it up on a website so I can wget it? It's troubling because I don't copy / paste from my terminal but I do a M-x insert-file in the message. Never mind, I'll send the attached file to you. -- Nicolas Baradakis - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
