> From: Nicolas Baradakis > Sent: Friday, 19 September 2003 6:28 PM > Paul Hampson wrote: > > > > > The following patch allow for SQL logging after authentication. It > > > > extends the rlm_sql module so now you can put one more query in your > > > > sql.conf file. > > > > > > I'll commit this once either you tell me that it doesn't depend on > > > Post-Auth-Type, or I commit the Post-Auth-Type patch. (Which I'm > > > going to look at now.) > > Well, the patch will apply without a problem but it is much less > interesting because you can query the db only if the authentication > step is successful.
True. That's not a dependancy though. To me, a patch dependancy means that it won't apply cleanly (or will work surprisingly) without the other patch. > > > With one minor change, to call > > > (inst->module->sql_finish_query)(sqlsocket, inst->config); > > > even for failed queries. (As is done in _some_ of the other sql_ > > > function in rlm_sql.c. And PostgresSQL's docs also do it... Only > > > postgres and Sybase (off hand, Oracle too maybe) actually implement > > > the function anyway. > > I don't understand. There is a return RLM_MODULE_FAIL just above, so > sql_finish_query() is not called on failed query. That's my point. My reading says it _should_ be. This certainly needs to be cleaned up in other places too. -- ========================================================= Paul "TBBle" Hampson Bubblesworth Pty Ltd (ABN: 51 095 284 361) [EMAIL PROTECTED] On a sidewalk near Portland State University someone wrote `Trust Jesus', and someone else wrote `But Cut the Cards'. --------------------------------------------------------- Random signature generator 3.0 by Paul "TBBle" Hampson ========================================================= - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
