Dave Mason <[EMAIL PROTECTED]> wrote:
> My module returns "RLM_OK" if it works and "RLM_NOOP" if not.

  Why?  That's what RLM_MODULE_FAIL is for.

>  RFC 2866 says that if an accounting record cannot be stored, no
> response should be sent.  I find that if I have only two accounting
> modules turned on, acct_unique and my module, and my module returns
> noop because of a failure, Freeradius still sends an
> Accounting-Response.

  So make your module return FAIL.

> It appears that acct_unique always returns OK.  Maybe that's the
> problem?

  No.

>   Should acct_unique return noop?

  Only if it does nothing.

>  FYI, my module needs to return noop on a failure, rather than
> RLM_FAILURE, so that other modules like detail still run even if
> mine fails.

  Then why are you wondering why FreeRADIUS responds with an
Accounting-Response?  You told it everything was OK.

  If you want "detail" to run even if your module fails, list "detail"
before your module in the "accounting" section.

  Alan DeKok.

- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Reply via email to