On Mon, 7 Mar 2005 [EMAIL PROTECTED] wrote:


I've run in to a snag with dialupadmin 1.0.1. Our usernames have spaces. I did not see that as a limitation in the docs. The only place it seems to be a problem is when administering group membership. A space as well as a new line defines the username to be assigned. I'd like to eliminate the space delimiter, but I just don't see how to do it. Can someone please help me?

The attached change should do the trick then


- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


-- Kostas Kalevras Network Operations Center [EMAIL PROTECTED] National Technical University of Athens, Greece Work Phone: +30 210 7721861 'Go back to the shadow' Gandalf
Index: lib/sql/create_group.php3
===================================================================
RCS file: /source/radiusd/dialup_admin/lib/sql/create_group.php3,v
retrieving revision 1.12
diff -u -r1.12 create_group.php3
--- lib/sql/create_group.php3   27 Oct 2004 11:22:41 -0000      1.12
+++ lib/sql/create_group.php3   8 Mar 2005 15:14:20 -0000
@@ -15,7 +15,7 @@
 $op_val2 = '';
 $link = @da_sql_pconnect($config);
 if ($link){
-       $Members = preg_split("/[\n\s]+/",$members,-1,PREG_SPLIT_NO_EMPTY);
+       $Members = preg_split("/[\n]+/",$members,-1,PREG_SPLIT_NO_EMPTY);
        if (!empty($Members)){
                foreach ($Members as $member){
                        $member = da_sql_escape_string($member);
Index: lib/sql/group_admin.php3
===================================================================
RCS file: /source/radiusd/dialup_admin/lib/sql/group_admin.php3,v
retrieving revision 1.6
diff -u -r1.6 group_admin.php3
--- lib/sql/group_admin.php3    18 Apr 2004 14:28:14 -0000      1.6
+++ lib/sql/group_admin.php3    8 Mar 2005 15:14:21 -0000
@@ -17,7 +17,7 @@
                }
        }
        if ($new_members != ''){
-               $Members = 
preg_split("/[\n\s]+/",$new_members,-1,PREG_SPLIT_NO_EMPTY);
+               $Members = 
preg_split("/[\n]+/",$new_members,-1,PREG_SPLIT_NO_EMPTY);
                if (!empty($Members)){
                        foreach ($Members as $new_member){
                                $new_member = da_sql_escape_string($new_member);

Reply via email to