Stefan Winter <[EMAIL PROTECTED]> writes: > as I see, #335 didn't make it. Any particular reason or did it just get lost? > IIRC, adding it was considered okay?
I do of course not know why it was left out, but I noticed the following discussion a few days ago: aland: "If it doesn't change existing behavior, I'm OK with adding it in." stefan.winter: "existing behaviour is unchanged." So far, so good. But then you went on describing that existing behaviour in fact IS changed: "The speed-up is very marginal, but: as of yet, for every packet this if () condition is evaluated, and and in the vast majority of cases (whenever User-Name is present) it evals to true. After taking these lines out, the if eval is saved (kinda being true always). Overall, you save one boolean evaluation per packet." I understand that this change is what you want, but there MAY be someone depending on the existing behaviour. This change will then surely break their current working configuration. They can of course fix it by reconfiguring the server, taking this change into consideration, but that is NOT the way to do a stable release cycle. All above IMHO, of course. Bjørn - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
