Hi Mads
On Wed, Mar 9, 2011 at 10:39 AM, Mads Kiilerich <m...@kiilerich.com> wrote:
> We have the following files that (for good reasons) isn't a part of what
> we distribute with "make dist". Much of it is unused, outdated and broken.
>
> Is it OK to remove them? Archaeologists will be able to find them in the
> repo history anyway.
>
> channels/rdpdr/smartcard/scard.c
> channels/rdpdr/smartcard/scard.h
>
Agreed, it just needs to be documented somewhere that this code exists for
the developer who will develop the plugin
> channels/rdpsnd/rdpsnd.c
> channels/rdpsnd/rdpsnd.h
>
If this is unused and that we have sound support, why is it still there?
> doc/patches.txt
>
We could move that to the wiki
> tests/brushtest.c
> tests/brushtest.exe
> tests/brushtestMakefile
> tests/notepadbehindwordpad.c
> tests/notepadbehindwordpad.exe
>
I think we should get a separate git repository just for tools
> wireshark/packet-rdp.c
> wireshark/packet-rdp.h
> wireshark/readme.txt
>
The wireshark dissector should be included in "make dist" but it is not
outdated or broken. It will likely be enhanced by a student as part of
google summer of code. Just like the tools in test, we should probably just
get a second git repo just for tools.
>
> The rest of tests/ could probably go too.
>
I'd get rid of tests completely and move its usable contents to a separate
git repo
>
> I just added channels/rdpdbg to the build system - I assume that is
> something that should be maintained and kept in a working state?
>
It's compilable and "usable", but doesn't do anything. This is skeleton code
for a virtual channel plugin. The intent would be to write an integration
testing framework using a virtual channel plugin, which would enable us to
send commands to the server and compare results. For instance, a test could
be done to ensure proper file system operations by doing the corresponding
operations and using the server-side virtual channel plugin to verify that
the operation has been completed successfully.
I have been thinking about it for a while, what would you guys think of
switching from the sourceforge.net git repository to gitorious.org? It would
make things easier for maintaining two git repositories under the same
project. I'm not even sure if sourceforge.net allows that.
>
> /Mads
>
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> Freerdp-devel mailing list
> Freerdp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freerdp-devel
>
------------------------------------------------------------------------------
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
