On Mon, Apr 18, 2011 at 10:06 PM, Marc-André Moreau <
marcandre.mor...@gmail.com> wrote:
> Hi Vic,
>
> On Mon, Apr 18, 2011 at 9:38 PM, Vic Lee <ll...@163.com> wrote:
>
>> Hi Marc,
>>
>> I am wondering, if libgdi is intended to be used by UIs outside of
>> FreeRDP, for example, Remmina? If so, I think it's better to have its
>> headers installed and name it libfreerdpgdi?
>>
>
> Actually, there might be space for two separate libraries:
>
> gdi_color.c + gdi_window.c aren't really "libgdi", gdi_color.c contains
> color conversion code, and gdi_window.c contains UI functions that can be
> registered and that will make calls to the libgdi API.
>
> All the rest, gdi_*.c files, contain a re-implementation of GDI. Some stuff
> might be better if it is statically linked, not used as a shared library.
> For instance, certain UIs will use only certain color conversion paths,
> never others, so they can be disabled at linked time and simplified to just
> what is used in a particular context.
>
Replying to my own comment:
For instance, I looked at the color conversion code in wfreerdp, which swaps
the byte order, unlike the current code in gdi_color.c. I would need to
extend the color conversion code to support that as well in wfreerdp before
I could get rid of wf_color.cpp. However, we know that only a particular
conversion path is used in one context (byte reordering, or keeping original
byte order). One way to avoid checking every time is to statically link it
with a compile-time option enabling byte re-ordering or not. Another way
would be to have two functions, one for each case, and register a callback
once at runtime that then gets called, such that you don't need to check
every time you want to call it.
>
>> Vic
>>
>> On 04/19/2011 12:36 AM, Marc-André Moreau wrote:
>> > I have made a pull request here for this first step in the refactoring:
>> > https://github.com/FreeRDP/FreeRDP/pull/10
>> >
>> > Please comment
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Benefiting from Server Virtualization: Beyond Initial Workload
>> Consolidation -- Increasing the use of server virtualization is a top
>> priority.Virtualization can reduce costs, simplify management, and improve
>> application availability and disaster protection. Learn more about
>> boosting
>> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
>> _______________________________________________
>> Freerdp-devel mailing list
>> Freerdp-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/freerdp-devel
>>
>
>
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
