2011/8/27 Marc-André Moreau <marcandre.mor...@gmail.com>:
> Those packages are not that "optional" after all, they really break core
> features of xfreerdp if not used.
Maybe they should be required, then?
> Is it me or if the package is named
> optional, it is not included by default, even though the development package
> may be present on the system?
No, find_optional_package is a macro defined in cmake/FindOptionalPackage.cmake
if used it introduces two options for the dependency - one for
requiring (WITH_OPTION=ON) and one for ignoring (WITHOUT_OPTION=ON).
But in the default - that is if the user specifies none of the options
find_optional_package behaves exactly the same as find_package.
So in writing find_optional_package(Xext) this gets expanded to:
if(WITH_XEXT)
find_package(Xext REQUIRED)
elseif(NOT WITHOUT_XEXT)
find_package(Xext)
endif(WITH_XEXT)
and if neither -DWITH_XEXT=ON nor -DWITHOUT_XEXT=ON are specified this
equals to find__package(Xext).
This is for a bit more control of the optional dependencies. This way
I have the possibility to say
- I want to depend on Xext, and please fail if it not there. (-DWITH_XEXT=ON)
- I want to never depend on Xext, even if is currently installed on my
system (-DWITHOUT_XEXT=ON)
Thinking about what you wrote above - we could add another macro in
the same fashion (maybe find_suggested_package ?)
which in turn would require the package, but users could deactivate
this while calling cmake.
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Freerdp-devel mailing list
Freerdp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freerdp-devel
