Hi, On Fri, Oct 28, 2011 at 1:14 PM, D Sundstrom <su...@peapod.net> wrote:
> On Solaris we need to explicitly include X11.h in a couple of places > because the other headers don't pull that in. > > A couple of questions: > > 1) We need to link with "rt" -lrt on Solaris. I'm not familiar > enough with cmake to know exactly how I should add this flag for > Solaris. Any suggestions? > It's a matter of detecting solaris in cmake and adding rt to the link libraries. Which part of FreeRDP needs to be linked against rt? Just googling, I found this simple patch which detects Solaris in cmake for another project and adds solaris-specific options: http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-July/016197.html > > 2) How does one get commit privileges for this project? > We're using github, so all you need is a github account. You then "fork" the main FreeRDP repository, which effectively gives you your own repository in which you have all rights. You make your changes there, and then when you are ready, you create a pull request. The pull request will show the commits which you've added on your personal repository, and someone with access rights to the main repository will be able to accept to merge those changes in. > > Here is the patch: > > > >From 21dcb56a72c67e68cd35d28362a8d47487bd3bb3 Mon Sep 17 00:00:00 2001 > From: David Sundstrom <su...@peapod.net> > Date: Fri, 28 Oct 2011 11:27:09 -0500 > Subject: [PATCH] Add missing includes for Solaris > > --- > client/X11/xf_window.c | 1 + > libfreerdp-kbd/layouts_xkb.c | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/client/X11/xf_window.c b/client/X11/xf_window.c > index 3dee4b7..da217f3 100644 > --- a/client/X11/xf_window.c > +++ b/client/X11/xf_window.c > @@ -17,6 +17,7 @@ > * limitations under the License. > */ > > +#include <X11/Xlib.h> > #include <X11/Xutil.h> > #include <X11/Xatom.h> > > diff --git a/libfreerdp-kbd/layouts_xkb.c b/libfreerdp-kbd/layouts_xkb.c > index ceed0ae..df40ec0 100644 > --- a/libfreerdp-kbd/layouts_xkb.c > +++ b/libfreerdp-kbd/layouts_xkb.c > @@ -22,6 +22,7 @@ > #include <string.h> > > #ifdef WITH_XKBFILE > +#include <X11/Xlib.h> > #include <X11/XKBlib.h> > #include <X11/extensions/XKBfile.h> > #include <X11/extensions/XKBrules.h> > -- > 1.7.6.1 > > > ------------------------------------------------------------------------------ > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > _______________________________________________ > Freerdp-devel mailing list > Freerdp-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/freerdp-devel > ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Freerdp-devel mailing list Freerdp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
