Le 13/03/2015 22:35, Marc-André Moreau a écrit : > Hi Vincent, Hello Marc-André, Peter, > > Is there a particular reason why keyboard mapping fails in a thinlinc > environment? No I don't really know why keyboard mapping is faulty with FreeRDP in a thinlinc environment. Maybe because of the use of TigerVNC whose the protocol is based on "keysyms". So after desperately trying to "play" with setxkbmap, xmodmap etc ..., I finally decided to do some coding to make it works correctly.
> I just took a quick look at the modifications you made on that branch, > and it looks like you are dynamically loading the keymap files from > thinlinc and adding support for thinlinc-specific keyboard map names, > etc. If I understand correctly, no rdesktop code is used, and you are > not redistributing the thinlinc keymap files. Instead, you added code > to be able to load pre-existing keymaps and provide compatibility for > them. I would tend to say that since no rdesktop code is used and you > are not redistributing the keymaps, many would interpret this as being > perfectly fine from a licensing standpoint. However, I would check > with Peter first to see how he interprets it. > Actually, and to be honest, I looked into rdesktop code to try to understand why keyboards work with it and not with FreeRDP and I saw it uses keysyms loaded from a keymap file. After that, I'm trying to implement the use of this files in my own way (but I hope I haven't been too "influenced" by rdesktop code after reading it :-)) Peter, What is your opinion on this ? > Peter, what is your stand on this? ThinLinc is your product, and I > personally do not mind if some of our users want to improve FreeRDP > support for ThinLinc, but I do not want any trouble with you regarding > licensing. > > Best regards, > -Marc-Andre Best Regards, Vincent. > > > > > On Fri, Mar 13, 2015 at 4:46 PM, Vincent Sourin > <souri...@bridgestone-bae.com <mailto:souri...@bridgestone-bae.com>> > wrote: > > Hi Everyone, > > I allow myself to use this thread because I have also a question > regarding licensing. > > In my company, we use ThinLinc (https://www.cendio.com/). This > software > is shipped with rdesktop but we want to use FreeRDP instead. As in a > thinlinc environment we've some problems with non-us keyboards layouts > (belgian layout actually) with FreeRDP, I'm trying to modify it > (https://github.com/Vinche59/FreeRDP/tree/thinlinc-keyboard) to be > able > to use it. > > Not to reinvent the wheel, I am currently using keymaps files shipped > with rdesktop. > > From the perspective of the different licenses used in rdesktop & > FreeRDP do have I the right to use these files or not ? > > Thank you for your answers. > > Best Regards, > > Vincent. > > Le 13/03/2015 20:17, Marc-André Moreau a écrit : > > Hi, > > > > Code reuse is acceptable within the same project or with code of > the same > > license, but the last thing we want is reusing code with > licensing we don't > > want, like rdesktop. I understand it may look logical since the > amount of > > code appears too small and too simple to be copyrightable, but > as you can > > notice we are being watched very closely by the rdesktop project > for any > > opportunity to cry wolf on licensing. For this reason, you > should not reuse > > parts from rdesktop, as simple and small as they may appear to > you. This is > > not because I want to be a bitch about this, it is because > somebody else is > > already doing that job very well for me. > > > > This being said, simply throw whatever rdesktop-inspired code > you have > > there and start fresh. Don't bother using rdesktop code, the > stuff you > > describe looks simple enough to me so that you can write your > own without > > using rdesktop as a reference. The GSSAPI is fairly standard, > and I recall > > there are some good MSDN articles on SSPI/GSSAPI interop. I may > have one > > suggestion for a different way to interface with the GSSAPI that > may be > > better on the long term: would it be possible to dynamically > load the > > GSSAPI library instead of linking to it, just like what I have done > > previously for pcsc-lite? It is more work, but it would remove > the link > > dependency. > > > > Best regards, > > -Marc-Andre > > > > On Thu, Mar 12, 2015 at 4:55 PM, Thomas Calderon > <calderon.tho...@gmail.com <mailto:calderon.tho...@gmail.com>> > > wrote: > > > >> Hi, > >> > >> The code ported from rdsektop is minimal and isolated in > kerberos_gss.c, > >> it consists of wrappers around GSSAPI to be precise. I was just > trying to > >> apply code reuse. > >> I can easily rewrite it to have the same functionality so that > there is no > >> licensing issues. > >> > >> Is that something that could be acceptable? > >> > >> Cheers, > >> > >> Thomas. > >> Le 12 mars 2015 21:10, "Marc-André Moreau" > <marcandre.mor...@gmail.com <mailto:marcandre.mor...@gmail.com>> a > >> écrit : > >> > >> Thanks Peter for pointing it out, I was going to point it out > myself. > >>> Thomas, for obvious reasons we cannot consider accepting such a > >>> contribution in the FreeRDP project, as by your own words it > is based on > >>> code taken from rdesktop. Kerberos support in FreeRDP would be > nice, but it > >>> cannot be implemented by porting GPL code to our Apache 2.0 > code base. > >>> > >>> > >>> > >>> On Thu, Mar 12, 2015 at 4:00 PM, Peter Astrand > <astr...@cendio.se <mailto:astr...@cendio.se>> wrote: > >>> > >>>> On Thu, 12 Mar 2015, Thomas Calderon wrote: > >>>> > >>>>> I have started working on a PoC to support Kerberos > authentication for > >>>>> FreeRDP clients. > >>>>> The GSSAPI code was ported from the rdesktop project that > has support > >>>> for > >>>>> Kerberos client authentication. > >>>> Please note that due to the different licenses, it's not > possible to take > >>>> code from rdesktop and put it into FreeRDP. Code can flow > from FreeRDP to > >>>> rdesktop, but not the other way around, unless you start > distributing > >>>> FreeRDP under the GPLv3 license. (See > >>>> http://en.wikipedia.org/wiki/Apache_License#GPL_compatibility) > >>>> > >>>> > >>>> Br, > >>>> > >>>> > >>> > > > > --- > L'absence de virus dans ce courrier électronique a été vérifiée > par le logiciel antivirus Avast. > http://www.avast.com > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel > Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your > hub for all > things parallel software development, from weekly thought > leadership blogs to > news, videos, case studies, tutorials and more. Take a look and > join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > FreeRDP-devel mailing list > FreeRDP-devel@lists.sourceforge.net > <mailto:FreeRDP-devel@lists.sourceforge.net> > https://lists.sourceforge.net/lists/listinfo/freerdp-devel > > -- Sourin Vincent - Systems Engineer Bridgestone Aircraft Tire (Europe) Route de Bavay - B7080 Frameries (Belgium) Tel: +32 65 61 11 53 - Fax: +32 65 61 11 09 GSM : +32 492 97 44 99 --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. http://www.avast.com ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ FreeRDP-devel mailing list FreeRDP-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
