Hi, Thank you for the reply.
On Fri, Mar 13, 2015 at 8:17 PM, Marc-André Moreau < marcandre.mor...@gmail.com> wrote: > Hi, > > Code reuse is acceptable within the same project or with code of the same > license, but the last thing we want is reusing code with licensing we don't > want, like rdesktop. I understand it may look logical since the amount of > code appears too small and too simple to be copyrightable, but as you can > notice we are being watched very closely by the rdesktop project for any > opportunity to cry wolf on licensing. For this reason, you should not reuse > parts from rdesktop, as simple and small as they may appear to you. This is > not because I want to be a bitch about this, it is because somebody else is > already doing that job very well for me. > I was not aware of previous licensing issues between the two projects. Now, I do not know if you had the time to actually look at kerberos_gss.c which you argue could have licensing issues. It consists of less than 100 lines of code, as said previously wrapping licensing free GSSAPI functions. There is IMHO no IP in this code as it is basic and was adapted to FreeRDP semantic (using SecBuffer structures for instance). I do not see what changes it would bring to rewrite it except changing wrapper names or variables. However, I am convinced that having Kerberos support (at least for clients) is a MUST have in FreeRDP. If this view is shared among the FreeRDP community, and this portion of the code remains an issue, then I guess someone will have to rewrite it. > > This being said, simply throw whatever rdesktop-inspired code you have > there and start fresh. Don't bother using rdesktop code, the stuff you > describe looks simple enough to me so that you can write your own without > using rdesktop as a reference. The GSSAPI is fairly standard, and I recall > there are some good MSDN articles on SSPI/GSSAPI interop. I may have one > suggestion for a different way to interface with the GSSAPI that may be > better on the long term: would it be possible to dynamically load the > GSSAPI library instead of linking to it, just like what I have done > previously for pcsc-lite? It is more work, but it would remove the link > dependency. > I have not looked at the pcsc-lite code, but it sounds like this allows to dynamically add features through the use of library loading. This raises several questions related to security (how are the libraries located/loaded, can I inject my own library, how are paths resolved, etc). Linking at compile time allows to rely on the system loader instead of custom code that could allow to load arbitrary code. Cheers, Thomas. > > Best regards, > -Marc-Andre > > On Thu, Mar 12, 2015 at 4:55 PM, Thomas Calderon < > calderon.tho...@gmail.com> wrote: > >> Hi, >> >> The code ported from rdsektop is minimal and isolated in kerberos_gss.c, >> it consists of wrappers around GSSAPI to be precise. I was just trying to >> apply code reuse. >> I can easily rewrite it to have the same functionality so that there is >> no licensing issues. >> >> Is that something that could be acceptable? >> >> Cheers, >> >> Thomas. >> Le 12 mars 2015 21:10, "Marc-André Moreau" <marcandre.mor...@gmail.com> >> a écrit : >> >> Thanks Peter for pointing it out, I was going to point it out myself. >>> >>> Thomas, for obvious reasons we cannot consider accepting such a >>> contribution in the FreeRDP project, as by your own words it is based on >>> code taken from rdesktop. Kerberos support in FreeRDP would be nice, but it >>> cannot be implemented by porting GPL code to our Apache 2.0 code base. >>> >>> >>> >>> On Thu, Mar 12, 2015 at 4:00 PM, Peter Astrand <astr...@cendio.se> >>> wrote: >>> >>>> On Thu, 12 Mar 2015, Thomas Calderon wrote: >>>> >>>> > I have started working on a PoC to support Kerberos authentication for >>>> > FreeRDP clients. >>>> >>>> > The GSSAPI code was ported from the rdesktop project that has support >>>> for >>>> > Kerberos client authentication. >>>> >>>> Please note that due to the different licenses, it's not possible to >>>> take >>>> code from rdesktop and put it into FreeRDP. Code can flow from FreeRDP >>>> to >>>> rdesktop, but not the other way around, unless you start distributing >>>> FreeRDP under the GPLv3 license. (See >>>> http://en.wikipedia.org/wiki/Apache_License#GPL_compatibility) >>>> >>>> >>>> Br, >>>> --- >>>> Peter Astrand ThinLinc Chief Developer >>>> Cendio AB https://cendio.com >>>> Teknikringen 8 https://twitter.com/ThinLinc >>>> 583 30 Linkoping https://facebook.com/ThinLinc >>>> Phone: +46-13-214600 https://google.com/+CendioThinLinc >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Dive into the World of Parallel Programming The Go Parallel Website, >>>> sponsored >>>> by Intel and developed in partnership with Slashdot Media, is your hub >>>> for all >>>> things parallel software development, from weekly thought leadership >>>> blogs to >>>> news, videos, case studies, tutorials and more. Take a look and join the >>>> conversation now. http://goparallel.sourceforge.net/ >>>> _______________________________________________ >>>> FreeRDP-devel mailing list >>>> FreeRDP-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/freerdp-devel >>>> >>> >>> > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ FreeRDP-devel mailing list FreeRDP-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freerdp-devel
