On Fri, Jan 18, 2002 at 12:09:19PM +0100, [EMAIL PROTECTED]
wrote:
> * src/sound/sound.c: Altered API to allow more data to flow down to
> the MIDI driver.
What for? Nothing seems to use other_data now, and I fail to see what
it was added for.
The mechanism you chose is so limited that it's useless for the generic
case. Since teh soundserver does not know what midi device it's using,
it can't put device-specific stuff in that other_data column. Likewise,
the midiout layer doesn't know what device is being used. A MIDI event
is only 2 or three bytes, not three or four, so this other_data won't be
used at the midi level of things.
If there's something specific the lower layers need to know, they should
have a dedicated api call to inform them of this data, not a "generic"
per-note mechanism that's not generic at all.
The only thing I can think of that the lower midi-layer stuff may need
to know is the polyphony count, but that doesn't change on a
note-by-note basis, and shoudl only be changed when a song is
initialized.
And besides. You changed not only the external API, but the internal
API too -- and things are fux0red up with the compile because you didn't
change things everywhere. I'm amazed all I get are a few warnings
instead of things crashing madly. I guess the gnu linker has a lot of
magic going on behind the scenes.
- Pizza
--
Solomon Peachy pizzaATfucktheusers.org
I ain't broke, but I'm badly bent. ICQ# 1318344
Patience comes to those who wait.
...It's not "Beanbag Love", it's a "Transanimate Relationship"...
-- Attached file included as plaintext by Listar --
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE8SET+ysXuytMhc5ERAvZBAJ9shiJiehy+oYFoh7Qd0+Wcpj7rDwCghhBi
aX2RowkBhr2It5yvRrtObvg=
=TfnA
-----END PGP SIGNATURE-----
