The kind of optimizations he's considering would cause small differences
in floating point computation, leading to something that's not bit-exact
even when the codec is working correctly. You'd have to turn them off
for testing until we decide what deltas are acceptable in our tests.
However, fixing the static vs. global problems, aliasing, and other
things that make optimizations less likely should still yield bit-exact
code. We can safely encourage that work.
Thanks
Bruce
On 01/28/2013 09:00 PM, David Rowe wrote:
> Hello Albert,
>
>> BTW, the unittest code has a similar problem that prevents
>> marking library functions static. This blocks the compiler from
>> performing some kinds of optimization.
> At the moment no one is actually asking us to make Codec 2 run faster.
> For example it runs just fine when used with FreeDV. So faster code on
> a specific platform is a nice to have rather than something that
> justifies significant code changes.
>
> If the code changes are minor and it runs faster, that's fine. However
> the priority is to ensure the codec is not broken in some subtle way.
> The best way is make sure the output (e.g. bit stream, decoded speech
> samples) after any optimisation is bit exact with what it was before
> optimisation. Pls demonstrate this before checking in any modified
> code.
>
> Thanks,
>
> David
>
>
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. ON SALE this month only -- learn more at:
> http://p.sf.net/sfu/learnnow-d2d
> _______________________________________________
> Freetel-codec2 mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/freetel-codec2
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
Freetel-codec2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freetel-codec2
