I recommend we include the sox source files we need in our source repository. Relying on the system sox lib whose internal implementation will vary over time and different machines is too risky.
I'm uneasy with the assumption the latest version of sox installed in the system will be OK. Although maybe I'm wrong. At a minimum pls make sure tools-filter is tested on several systems if the system lib is used. It's not sufficient to have it just build OK. I've had reports of this feature crashing on some Linux/Mac systems (although this cld be some other bug of course) I use just a few internal sox functions for the tools-filter feature. Stuff like biquad filters. At some stage it would be nice for some one to work out exactly which sox source files we need. Cheers, David On Wed, 2013-05-22 at 13:19 -0500, Richard Shaw wrote: > On Tue, May 21, 2013 at 3:56 PM, David Rowe <[email protected]> wrote: > > freedv: effects_i_dsp.c:118: clear_fft_cache: Assertion > `fft_len >= 0' failed. > > > Thanks Joel and Richard. > > This is a file in sox. Can I suggest trying to use the actual > sox > source files (as per src/Makefile.linux), not a sox version > installed in > the system? To implement the filter functions I used > functions internal > to sox rather than the sox API. This is going to be very > unstable > across SOX versions. > > > Since my eventual plan is to move from a self hosted repository to > including it in Fedora proper, I am required to use the system > libraries unless I get an exception to bundle from the board, but > Fedora tends to run more recent version of most packages compared to > Debian so I don't expect it to be an issue. > > > As to the Windows installer I built, I downloaded and built the > current release and packaged the DLL with it so we should be good > there, other than the problem at hand. From what I've gathered, we > don't use much of the functionality from SOX so perhaps the best > option there is to incorporate them in the source and drop it as a > dependency. > > > Richard > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may > _______________________________________________ Freetel-codec2 mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freetel-codec2 ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ Freetel-codec2 mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freetel-codec2
