Hi Richard, This sort of structural change is something we must collaborate on, as it impacts my day-day work on Codec 2 and FreeDV.
I agree it does make sense to move the fdmdv modem and golay code away from the codec, although the number of files is small at this stage (i.e. just 2 for the golay code). Not sure if this warrants an extra library. What do others on the list think? Some thoughts: + the golay codes implements forward error correction (FEC). Its a different layer from the modem. So the name "rfmodem" is not suitable. + Not sure about the name "rfmodem" for the fdmdv code. Once again RF is a different layer to the modem. "fdmdv" or "modem" would be a good name for the modem code, perhaps "fec" for the FEC code. generic names like modem/fec would support the addition of other modem/FEC code to the library later. + Pls ensure all programs using the golay code (and the modem code if you move that) still work, e.g. the unitttests and utilities in src, the various command line simulations, and FreeDV (Windows and Linux). This will require some maintenance and testing of the autotools & Makefile.linux/Makefile.win32 build system at this time. You can see how I used the command line simulations on the various FreeDV robustness blog posts. + Structural changes are a "nice to have" for me. However it's more important to me that nothing breaks and _everything_ is thoroughly tested. If the structural changes can happen without anything breaking then that's great. I simply don't have the bandwidth to support these changes myself by tracking down any resulting build issues. + Pls carefully test all programs that are impacted by these changes. Cheers, David On Mon, 2013-06-17 at 15:40 -0500, Richard Shaw wrote: > Ok, per Bruces direction, I have created a new directory under freetel > called "rfmodem". > > > I have copied (for now) the golay23 sources there and created a basic > cmake config for building and installing the library. > > > Should I assume that the same COPYING file needs to be in the rfmodem > directory? (LGPL v2.1?) > > > Thanks, > Richard > ------------------------------------------------------------------------------ > This SF.net email is sponsored by Windows: > > Build for Windows Store. > > http://p.sf.net/sfu/windows-dev2dev > _______________________________________________ Freetel-codec2 mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freetel-codec2 ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Freetel-codec2 mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freetel-codec2
