Hi Alan,
Good catch, looks like that if-then won't be doing much and *valid will
always be 1. That's in code for the the earlier 700 modes (pre 700D)
... so not sure if it's worth running to ground at this stage. Squelch
appears to be working fine in 700D.
- David
On 29/08/18 16:16, Alan Beard wrote:
> Hi David and team,
>
> in src/freedv_api.c at line 1655 or there abouts:
>
> if (f->squelch_en && (f->stats.snr_est < f->snr_squelch_thresh)) {
> *valid = 0;
> }
> *valid = 1;
>
>
> Will *valid ever be zero when squelch is set?
>
> Alan VK2ZIW
>
> Evil flourishes when good men do nothing.
> Consider the Christmas child.
> ---------------------------------------------------------------------------
> Alan Beard Unix Support Technician from 1984 to today
> 70 Wedmore Rd. Sun Solaris, AIX, HP/UX, Linux, SCO, MIPS
> Emu Heights N.S.W. 2750 Routers, terminal servers, printers, terminals etc..
> +61 2 47353013 (h) Support Programming, shell scripting, "C", assembler
> 0414 353013 (mobile) After uni, electronics tech
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Freetel-codec2 mailing list
> Freetel-codec2@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/freetel-codec2
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Freetel-codec2 mailing list
Freetel-codec2@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freetel-codec2
