[EMAIL PROTECTED] wrote: > Update of /cvsroot/freevo/freevo/src > In directory sc8-pr-cvs1:/tmp/cvs-serv14711/src > > Modified Files: > directory.py > Log Message: > Support icons instead of labels "on", "off" and "auto"
As much as I like the optic of that, please don't include such things before 1.4 final. The reason is, that it didn't work with all skins. Noia has a different icon theme. The effect was that I didn't get text or icons here. This is bad. You also changed the table syntax (from percent to pixel). First, don't change any sytax before 1.4 without writing a mail. Second, don't use pixel sizes. It doesn't scale. You used 30 pixel. 30 pixel look different in 640x480 and 1024x768 because only the skin fxd values scale, not something inside the code. You also wrote that it's a hack when you hardcoded the string names in the skin. Please, no hacks before 1.4. We're trying to get it stable. What I did to fix it: First, I moved back to percent values in the table. To avoid hardcoding strings in the skin, I added a pattern to switch to icon mode: ICON_<POSITION>_<IMAGE>_<TEXT>. Only if the text matches that pattern (ICON_ and 3 _ in the text), a new function will come active: search if image exists, if not, use the text. This makes it possible to use the text if the image doesn't exists. To make it look better, POSITION can be used to CENTER the image/text or put it to the RIGHT side. The code searches for the image based on the icon_dir set, no need to add it to the fxd file. Dischi -- while(!asleep) sheep++; ------------------------------------------------------- This SF.net email is sponsored by OSDN developer relations Here's your chance to show off your extensive product knowledge We want to know what you know. Tell us and you have a chance to win $100 http://www.zoomerang.com/survey.zgi?HRPT1X3RYQNC5V4MLNSV3E54 _______________________________________________ Freevo-cvslog mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-cvslog
