--- Dirk Meyer <[EMAIL PROTECTED]> escreveu: > [EMAIL PROTECTED] wrote: > > Update of /cvsroot/freevo/freevo/src > > In directory sc8-pr-cvs1:/tmp/cvs-serv14711/src > > > > Modified Files: > > directory.py > > Log Message: > > Support icons instead of labels "on", "off" and "auto" > > As much as I like the optic of that, please don't include such things > before 1.4 final.
Really sorry. It was a mistake, I should wait. > The reason is, that it didn't work with all skins. Noia has a > different icon theme. You can copy those icons until we find better ones. > The effect was that I didn't get text or icons > here. This is bad. Really? In my tests I get text when no image were found. > You also changed the table syntax (from percent to > pixel). First, don't change any sytax before 1.4 without writing a > mail. I'm sorry. > Second, don't use pixel sizes. It doesn't scale. You used 30 > pixel. 30 pixel look different in 640x480 and 1024x768 because only > the skin fxd values scale, not something inside the code. I will implement a way to use values between 0 and 1 to set percentages. When using images you can save some space using the same width as the image... Does freevo auto-scale images too? Also, is it used elsewhere than directory.py? > You also > wrote that it's a hack when you hardcoded the string names in the > skin. Please, no hacks before 1.4. We're trying to get it stable. Ok. > What I did to fix it: First, I moved back to percent values in the > table. To avoid hardcoding strings in the skin, I added a pattern to > switch to icon mode: ICON_<POSITION>_<IMAGE>_<TEXT>. Only if the text > matches that pattern (ICON_ and 3 _ in the text), a new function will > come active: search if image exists, if not, use the text. This makes > it possible to use the text if the image doesn't exists. To make it > look better, POSITION can be used to CENTER the image/text or put it > to the RIGHT side. The code searches for the image based on the > icon_dir set, no need to add it to the fxd file. Good approach. I used values in the fxd because we already do that for skins, so I wanted to be coherent. But since we're using that pattern, maybe we don't need to. However we must document that in the skin, so when one want to develop a new skin he will know it needs XYZ.png image. Really sorry for my mistakes. Gustavo Yahoo! Mail - o melhor webmail do Brasil http://mail.yahoo.com.br ------------------------------------------------------- This SF.net email is sponsored by: The SF.net Donation Program. Do you like what SourceForge.net is doing for the Open Source Community? Make a contribution, and help us add new features and functionality. Click here: http://sourceforge.net/donate/ _______________________________________________ Freevo-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freevo-devel
