Re: [Freevo-devel] Animation and Goom support in Freevo (and a patch)

[Jeff Oegema]

Hello, Just wanted to report an interesting issue with the current code.  I'm going to look through to try to find the reason but since I am not so adept I thought I'd report it as well. With the current animation code my mplayer seems to suspend shortly after activation and the animation doesn't appear.  This can be rectified and the animation started by pressing h to bring up the help screen and then returning to the player screen.  The animation will then start and the player run smoothly. This may not be of interest but I thought I'd drop it here. Jeff Jeff Oegema wrote: Hello, I wasn't a member of this list when the working pygoom was posted and I can't find it in the list archives.  Could you possibly send me a copy?  I would greatly appreciate it. Thanks for all the good work, Jeff Viggo Fredriksen wrote: On Sunday 25 April 2004 13:32, Dirk Meyer wrote: Hi, I just had some free time and added the animation stuff from Viggo to CVS. I made some changes and deactivated some stuff for the moment, so not everything is working as Viggo did it. o There is no animation thread. Threading is bad! I had some bad race conditions when detaching the screen. There is now a function sleep() in osd.py. Use this function to wait and it will update the animations. I was afraid it would perform bad when not having threads, but atleast visualization seems fast enough. I think that it may be a problem when doing animations while performing interactive tasks (browsing) - the animations will stop and therefore seem less smooth. o If you detach the player, there is no goom animation right now. Maybe someone can add it later, but since goom sets the animation to realtime (== no sleep), Freevo gets slow. So goom is only working when you see the player. I will look into this issue and see if I can find a comfortable solution. The version I sent only supported detached view on the idlebar anyway, so it was not ready for inclusion. o I also removed the screensaver patch for now, the image viewer patch is included. Also the text animation is not in cvs now. It would be great to have animated selected text in the menus, but my attempts to do this so far has been unsatisfactory. I couldn't find a proper way to stop the animation when some other app took over control (player, imageviewer etc.). I hope someone will do this sooner or later though. I'll see if I can code an alternative to the osd.drawstringanimate in the animation namespace. o pygoom itself is not included. We need to find a good way to add it to cvs. Suggestions? For now, I included the latest version I got from Viggo to this mail. As Gustavo stated, it's not much point in doing more with this version - hopefully in the not-too-far future it will be obsoleted by libvisual. Have fun and great work Viggo. Thanks :) Dischi Attached is a patch for the imageviewer and transition.py, adding IMAGEVIEWER_BLEND_STYLE to the configs and including more steps in the viewer transitions (as discussed on IRC). The viewer.py had a mixture of '\t' and space chars, so I took the liberty to clean it. (actually kdevelop does it by itself.. but :P ) Regards Viggo Fredriksen -- Jeff Oegema CEO Scionics Computer Innovation GmbH http://www.scionics.de Phone: +49 351 312 3011 Fax: +49 351 312 3015 -- Jeff Oegema CEO Scionics Computer Innovation GmbH http://www.scionics.de Phone: +49 351 312 3011 Fax: +49 351 312 3015