Bugs item #1622456, was opened at 2006-12-26 16:14
Message generated for change (Comment added) made by ryanroth
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1622456&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: webserver
Group: 1.6 svn (rel-1-6)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: [EMAIL PROTECTED] (bacademy)
Assigned to: Nobody/Anonymous (nobody)
Summary: genre.rpy produces invalid html

Initial Comment:
When using the category filter in TV Guide, the resulting XML often renders as 
empty in Konqueror.

For instance, this is not valid:
        
fv.tableCell('<form>'+bforcell+_('Show')+'&nbsp;'+_('Category')+':&nbsp;'  
self.makecategorybox(allcategories,category)+stime+'<input type=submit  
value="'+_('Change')+'">'+aftercell+'</form>', 'class="guidehead"')

as the <form> tag should always contain the action=URL attribute.

W3C Markup Validation Service gives 24 errors for the attached genre.html




----------------------------------------------------------------------

Comment By: ryan (ryanroth)
Date: 2006-12-26 18:25

Message:
Logged In: YES 
user_id=1196812
Originator: NO

Index: src/www/htdocs/genre.rpy
===================================================================
--- src/www/htdocs/genre.rpy    (revision 8811)
+++ src/www/htdocs/genre.rpy    (working copy)
@@ -49,7 +49,7 @@
             cat = Unicode( cat )
             retval += u'<option value="%s" ' % cat
             if cat == category:
-                retval += u'SELECTED '
+                retval += u'SELECTED'
             retval += u'>%s</option>\n' % cat
         retval += u'</select>\n'
         return retval
@@ -107,7 +107,7 @@
             keepcat = '&category=%s' % category
         bforcell=''
         acelltime=mfrnextguide + 60
-        aftercell='&nbsp;&nbsp;&nbsp;<a href="genre.rpy?stime=%i%s"><img
src="images/RightArrow.png" border="0"></a>' % (acelltime, keepcat)
+        aftercell='&nbsp;&nbsp;&nbsp;<a href="genre.rpy?stime=%i%s"><img
src="images/RightArrow.png" border="0"></img></a>' % (acelltime, keepcat)
         if mfrprevguide > 0:
             bforcell='<a href="genre.rpy?stime=%i%s"><img
src="images/LeftArrow.png" border="0"></a>&nbsp;&nbsp;&nbsp;' %
(mfrprevguide, keepcat)

@@ -162,7 +162,7 @@
                     fv.tableCell(chan.displayname, 'class="channel"')
                     popid = '%s:%s' % (prog.channel_id, prog.start)

-                    fv.tableCell(prog.title + '&nbsp;&nbsp;-&nbsp;&nbsp;'
+ prog.desc, 'class="'+status+'" onclick="guide_click(this, event)" id="%s"
 width="80%%"' % popid )
+                    fv.tableCell(prog.title + '&nbsp;&nbsp;-&nbsp;&nbsp;'
+ prog.desc, 'class="'+status+'" onclick="guide_click(this, event)" id="%s"
 width="80%%" action=""' % popid )
                     fv.tableCell(time.strftime('%H:%M',
time.localtime(prog.start)), 'class="channel"')
                     fv.tableCell(time.strftime('%H:%M',
time.localtime(prog.stop)), 'class="channel"')
                     fv.tableRowClose()


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1622456&group_id=46652

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to