Bugs item #1622456, was opened at 2006-12-26 17:14
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1622456&group_id=46652
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: webserver
Group: 1.6 svn (rel-1-6)
>Status: Pending
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: [EMAIL PROTECTED] (bacademy)
Assigned to: Nobody/Anonymous (nobody)
Summary: genre.rpy produces invalid html
Initial Comment:
When using the category filter in TV Guide, the resulting XML often renders as
empty in Konqueror.
For instance, this is not valid:
fv.tableCell('<form>'+bforcell+_('Show')+' '+_('Category')+': '
self.makecategorybox(allcategories,category)+stime+'<input type=submit
value="'+_('Change')+'">'+aftercell+'</form>', 'class="guidehead"')
as the <form> tag should always contain the action=URL attribute.
W3C Markup Validation Service gives 24 errors for the attached genre.html
----------------------------------------------------------------------
>Comment By: Duncan Webb (duncanwebb)
Date: 2006-12-27 00:18
Message:
Logged In: YES
user_id=104395
Originator: NO
Thanks, the patch has been applied to rel-1 at r8815.
Will someone confirm that it works?
The change still need to be done for rel-1-6
----------------------------------------------------------------------
Comment By: ryan (ryanroth)
Date: 2006-12-26 19:26
Message:
Logged In: YES
user_id=1196812
Originator: NO
The patch below should solve your "action=URL" issue, and some issues with
broken img tags.
----------------------------------------------------------------------
Comment By: ryan (ryanroth)
Date: 2006-12-26 19:25
Message:
Logged In: YES
user_id=1196812
Originator: NO
Index: src/www/htdocs/genre.rpy
===================================================================
--- src/www/htdocs/genre.rpy (revision 8811)
+++ src/www/htdocs/genre.rpy (working copy)
@@ -49,7 +49,7 @@
cat = Unicode( cat )
retval += u'<option value="%s" ' % cat
if cat == category:
- retval += u'SELECTED '
+ retval += u'SELECTED'
retval += u'>%s</option>\n' % cat
retval += u'</select>\n'
return retval
@@ -107,7 +107,7 @@
keepcat = '&category=%s' % category
bforcell=''
acelltime=mfrnextguide + 60
- aftercell=' <a href="genre.rpy?stime=%i%s"><img
src="images/RightArrow.png" border="0"></a>' % (acelltime, keepcat)
+ aftercell=' <a href="genre.rpy?stime=%i%s"><img
src="images/RightArrow.png" border="0"></img></a>' % (acelltime, keepcat)
if mfrprevguide > 0:
bforcell='<a href="genre.rpy?stime=%i%s"><img
src="images/LeftArrow.png" border="0"></a> ' %
(mfrprevguide, keepcat)
@@ -162,7 +162,7 @@
fv.tableCell(chan.displayname, 'class="channel"')
popid = '%s:%s' % (prog.channel_id, prog.start)
- fv.tableCell(prog.title + ' - '
+ prog.desc, 'class="'+status+'" onclick="guide_click(this, event)" id="%s"
width="80%%"' % popid )
+ fv.tableCell(prog.title + ' - '
+ prog.desc, 'class="'+status+'" onclick="guide_click(this, event)" id="%s"
width="80%%" action=""' % popid )
fv.tableCell(time.strftime('%H:%M',
time.localtime(prog.start)), 'class="channel"')
fv.tableCell(time.strftime('%H:%M',
time.localtime(prog.stop)), 'class="channel"')
fv.tableRowClose()
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1622456&group_id=46652
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
