Chandan Pitta wrote: >> A bit more work than I expected to update the cache so that it works in >> the same way as normal cache. Especially, as I hadn't committed Wout's >> patch until too late, meaning that I had to apply the patch by hand. >> >> Let's hope that I didn't break anything else in the process. Quite a few >> files changed to this and a few function names too. > > Actually a few things broke ;). I won't blame you since I know how it > is to apply patches to the same file on the same revision from various > people. You did a nice job in putting things back again. However I saw > the following issues and fixed them > > 1. If you delete a cached image and then use webserver and click on > the image, you will see that the image is scaled to 200x200 (with > aspect) in the pop-up window. This happens because the return value of > fileops.create_www_thumbnail() is the size of the thumbnail image. I > fixed it to return the size of the original image. > > 2. The fileops.get_www_thumbnail_size() returns the size of the image > and not the size of the thumbnail. Anyway we don't use that method > anywhere, so I deleted that.
Ok > 3. Images files in cache have double extensions, like my_image.png.png > and in some extreme cases like for gif files there are 3 extensions, > like my_image.gif.gif.jpg. So I made some changes so that the cached > image filename will be exactly the same as the original image except > for the case of gif files. The double extensions are important for cache when removing cached images for images that no longer exist, we need to get the exact filename. The bugs in imlib2 incorrectly saving files with upper case and .gif extensions. >> One thing that is puzzling me is why is it slow, any idea. > > What is slow? I lost the context here. Do you mean the "freevo cache" > or the webpage loading or something else? The webserver loading pages is very slow. I think we need minimize the use of metadata.parse as it is quite slow and minimize opening images, this is slow too. The height and width of images seems to be already cached as info['height'] and info['width']. I haven't changed this but have left a print in there so you can see what is happening. >> >> The same fix that you did to bring the window to focus for the images >> could be applied to the remote on the index page. > > I did this fix also. Now it is your turn to test :P I can't see the use of the play, pause and stop buttons on the index page, we can get rid of these. I shall commit the changes now. Duncan ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
