Duncan Webb wrote:
> Chandan Pitta wrote:
>>>>> One thing that is puzzling me is why is it slow, any idea.
>>>> What is slow? I lost the context here. Do you mean the "freevo cache"
>>>> or the webpage loading or something else?
>>> The webserver loading pages is very slow.
>>>
>>> I think we need minimize the use of metadata.parse as it is quite slow
>>> and minimize opening images, this is slow too.
>>>
>>> The height and width of images seems to be already cached as
>>> info['height'] and info['width']. I haven't changed this but have left a
>>> print in there so you can see what is happening.
>> You are right, the size is already cached and it makes sense to use
>> it. I made this change and removed the print statement.
>>
>>
>>>>> The same fix that you did to bring the window to focus for the images
>>>>> could be applied to the remote on the index page.
>>>> I did this fix also. Now it is your turn to test  :P
>>> I can't see the use of the play, pause and stop buttons on the index
>>> page, we can get rid of these.
>> I removed these in the patch. Please review the code and apply.
> 
> Cool, this should speed up the loading of the pages a bit. We may even
> be able to remove metadata because the images are cached and converted
> to freevo raw image (FRI) and has the width and height encoded in the
> header. This will speed up the loop for images quite a bit. But this
> needs looking into.

This last change has made a huge difference loading the web library
image pages when the images are large; 7.2 mega pixel cameras generate
jpegs at about 3 MB, so I guess that not having to read the image in to
determine the size has made the difference.

Duncan


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to