[EMAIL PROTECTED] schrieb: > Tanja, I wonder whether a better approach would be to factor the > scrollable full description stuff off into a separate file/class for use > by all (tvguide/recordings manager/video items/music etc) components or > perhaps add a new layout for video items that includes cover art?
Hi Adam, I also thought of that, but I did not understand enough of this skin business. You are the skin expert :-) At the moment my plan is to add a scrollable item for all kinds of items that might need it. I already have the recodings manager ready, but I do want to wait with the submit until all other patches, that I already sent, are savely in the svn. To much at a time brings confusion, as I realized ;-) I also have the AudioItem on my to do list, for the lyrics plugin. So, if you can do the refactoring, that would be great! When I was thinking about that, I saw two problems. 1.) The eventhandler might be special to the item, e.g. as the programitem also needs to answer to REC. 2.) The information one want to display might be different, e.g. plot description in the VideoItem and ProgramItem and Lyrics in the AudioItem and who knows what else. This might be solved, by putting the text constuction in the charge of the Item that wants to use the scrollable description. Moreover I wondered, if the skin.py file is really the right place for this scrollable stuff, but as I said, I never understood that completly and therefor decide to touch it as less as possible ;-) Again, I really like this scrollable area, it is really a great improvement and probably with time there will be more and more new additions which will use it. Refactoring would be great! Regards Tanja ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Freevo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-devel
