> [EMAIL PROTECTED] schrieb: >> Tanja, I wonder whether a better approach would be to factor the >> scrollable full description stuff off into a separate file/class for use >> by all (tvguide/recordings manager/video items/music etc) components or >> perhaps add a new layout for video items that includes cover art? > [snip] > > So, if you can do the refactoring, that would be great! > When I was thinking about that, I saw two problems. > 1.) The eventhandler might be special to the item, e.g. as the programitem > also > needs to answer to REC.
I think we can get round this by either subclass the base class that will handle the scrolling text or by having a callback function. Which one do people prefer? > 2.) The information one want to display might be different, e.g. plot > description > in the VideoItem and ProgramItem and Lyrics in the AudioItem and who knows > what else. > This might be solved, by putting the text constuction in the charge of the > Item that > wants to use the scrollable description. I was just thinking that after having a quick browse of how its currently used, this does seem the simplest/most sensible solution. > Moreover I wondered, if the skin.py file is really the right place for > this scrollable stuff, I agree, but it was a case of 'hmm, where shall I put it' and I was expecting people to say 'not there, but how about here...' :-) I wondering whether to move the skin.py file into skin/init.py and the data models into skin/models.py (notice thats skin not skins) > but as I said, I never understood that completly and therefor decide to > touch it as less > as possible ;-) > > Again, I really like this scrollable area, it is really a great > improvement > and probably with time there will be more and more new additions which > will use it. > Refactoring would be great! I'm also open for suggestion on the Text Entry component, I think this has a great deal of potential for things like Video/Audio item search, renaming files/favourites, dialling phone numbers, anything that requires the user enter more than a simple selection. What would be really good is for someone who has knowledge of right-to-left text input to improve the code so that was supported as well. And finally ideas for how best to make the keyboard internationalised via possible the translations.... Cheers Adam ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Freevo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-devel
