> Duncan Webb wrote: >> Dirk Meyer wrote: >> | Duncan Webb wrote: >> |> Dirk Meyer wrote: >> |> | Dirk Meyer wrote: >> |> |> Hi, >> |> |> >> |> |> the current kaa.metadata VCD and SVCD detection code is buggy so I >> |> |> made some improvements. I hope this works now. Everyone with a VCD >> or >> |> |> a SVCD somewhere, please test it with as much discs as possible. >> You >> |> |> can get the test code at http://files.sachmittel.de/vcdtest.py >> |> | >> |> | Please run it with 'python vcdtest.py /path/to/disc' >> |> >> |> Different results for svcd and vcd... >> | >> | Can you send me the first 1MB if the not detected discs please. Or >> | find out what part of my tests fail in the test app. >> >> |>> f.seek(2048*16 + 1024, 0) >> |>> f.read(8) >> 'CD-XA001' >> |>> f.seek(2048*150, 0) >> |>> f.read(8) >> 'SUPERVCD' >> |>> f.seek(2048*16, 0) >> |>> iso9660 = f.read(2048*16) >> |>> iso9660.find('MPEGAV') >> -1 >> |>> iso9660.find('MPEG2') >> 4275 >> |>> iso9660.find('SVCD') >> 50 >> >> The last find is incorrect as has found the title: >> |>> iso9660[40:60] >> 'ELIZABETH_SVCD ' >> The real SVCD is: >> |>> iso9660[4380:4390] >> '\x04SVCD\x00\x00\x00\x00\x00' > > Title is bad. You could have a SVCD named MOVIE_VCD and everything is > wrong. But in your case the detection should have worked.
You missed this, in the code it only check for VIDEO_CD, so it didn't get as far a the later checks. f.seek(2048*150, 0) f.read(8) 'SUPERVCD' Trouble is I can't remember what tools I used to make this SVCD, it was five years ago. But it all valid SVCD have the SUPERVCD string here then there's no point in checking for VCD later. > >> Does this help? > > Yes and no. The first 1 MB would still be great to have. I'll see if I can find the sources and write another CD. Duncan ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
