On Jan 15, 2008 8:00 PM, Duncan Webb <[EMAIL PROTECTED]> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Duncan Webb wrote:
> |> Duncan Webb wrote:
> |>> Dirk Meyer wrote:
> |>> | Duncan Webb wrote:
> |>> |> Dirk Meyer wrote:
> |>> |> | Dirk Meyer wrote:
> |>> |> |> Hi,
> |>> |> |>
> |>> |> |> the current kaa.metadata VCD and SVCD detection code is buggy so
> I
> |>> |> |> made some improvements. I hope this works now. Everyone with a
> VCD
> |>> or
> |>> |> |> a SVCD somewhere, please test it with as much discs as possible.
> |>> You
> |>> |> |> can get the test code at http://files.sachmittel.de/vcdtest.py
> |>> |> |
> |>> |> | Please run it with 'python vcdtest.py /path/to/disc'
> |>> |>
> |>> |> Different results for svcd and vcd...
> |>> |
> |>> | Can you send me the first 1MB if the not detected discs please. Or
> |>> | find out what part of my tests fail in the test app.
> |>>
> |>> |>> f.seek(2048*16 + 1024, 0)
> |>> |>> f.read(8)
> |>> 'CD-XA001'
> |>> |>> f.seek(2048*150, 0)
> |>> |>> f.read(8)
> |>> 'SUPERVCD'
> |>> |>> f.seek(2048*16, 0)
> |>> |>> iso9660 = f.read(2048*16)
> |>> |>> iso9660.find('MPEGAV')
> |>> -1
> |>> |>> iso9660.find('MPEG2')
> |>> 4275
> |>> |>> iso9660.find('SVCD')
> |>> 50
> |>>
> |>> The last find is incorrect as has found the title:
> |>> |>> iso9660[40:60]
> |>> 'ELIZABETH_SVCD '
> |>> The real SVCD is:
> |>> |>> iso9660[4380:4390]
> |>> '\x04SVCD\x00\x00\x00\x00\x00'
> |> Title is bad. You could have a SVCD named MOVIE_VCD and everything is
> |> wrong. But in your case the detection should have worked.
> |
> | You missed this, in the code it only check for VIDEO_CD, so it didn't
> get
> | as far a the later checks.
> |
> | f.seek(2048*150, 0)
> | f.read(8)
> | 'SUPERVCD'
> |
> | Trouble is I can't remember what tools I used to make this SVCD, it was
> | five years ago. But it all valid SVCD have the SUPERVCD string here then
> | there's no point in checking for VCD later.
> |
> |>> Does this help?
> |> Yes and no. The first 1 MB would still be great to have.
> |
> | I'll see if I can find the sources and write another CD.
>
> I've modified the vcdtest.py a bit so that it works with the two (S)VCDs
> that I have.
>
I've tried Duncan's modified test, and it detects all the VCD's I've tried
so far as VCD's, so good job all of you!
(I've tried it on a stack of pressed Thai CD's)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
