On Sun, Nov 05, 2006 at 09:55:25PM +0100, Waldemar Brodkorb wrote:
> Hi,
> On Sun, 05 Nov 2006 at 20:14 +0100, Dirk Nehring wrote:
> > On Sun, Nov 05, 2006 at 06:26:51PM +0100, [EMAIL PROTECTED] wrote:
> > > Author: wbx
> > > Date: 2006-11-05 18:26:50 +0100 (Sun, 05 Nov 2006)
> > > New Revision: 1067
> > >
> > > Modified:
> > >    branches/freewrt_1_0/mk/modules-2.4.mk
> > >    
> > > branches/freewrt_1_0/target/linux/brcm-2.4/squashfs-overlay/config/config.squashfs_overlay
> > > Log:
> > > enable nls modules and some filesystems in kernel config, create 
> > > kmod-nls-cp437 package, start for the nls/fs module cleanup
> > [...]
> > >
> > > Modified: 
> > > branches/freewrt_1_0/target/linux/brcm-2.4/squashfs-overlay/config/config.squashfs_overlay
> > > ===================================================================
> > > --- 
> > > branches/freewrt_1_0/target/linux/brcm-2.4/squashfs-overlay/config/config.squashfs_overlay
> > >     2006-11-05 15:33:04 UTC (rev 1066)
> > > +++ 
> > > branches/freewrt_1_0/target/linux/brcm-2.4/squashfs-overlay/config/config.squashfs_overlay
> > >     2006-11-05 17:26:50 UTC (rev 1067)
> > > @@ -1,5 +1,5 @@
> > >  #
> > > -# Automatically generated make config: don't edit
> > > +# Automatically generated by make menuconfig: don't edit
> >
> > OK, only a suggestion: we should use the same method to generate the
> > config file. As you see, your diff is rather long since I use "make
> > config" and you "make menuconfig". "make config" make nicer comments,
> > could all agree with this?
>
> Hmm. make config is asking for everything, so it takes very long to
> just enable one or two options. Is it really necessary to always
> generate with the same method? I see no functional change.

I really mean "make oldconfig". Just run it after making your changes
with "make menuconfig". It is like "diff -u" a unifier. Yes, there is
no functional change, but makes it a little bit easier.

Dirk
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers

Reply via email to