Ralf Hemmecke wrote: > > Hello, > > sorry that I am a bit late, but I've just browsed through configure.ac. > It seems to me that this code is missing a check whether gmp is actually > installed. >
True. I was thinking about good test and it looked that the best test is to compile the actual file (src/lib/gmp_wrap.c). However, since Makefiles are not ready at configure time we can not do this in regular way. So I decided to postpone this -- I you want to add test you are welcome. > http://www.gnu.org/software/gmp/manual/html_node/Autoconf.html > > Also, I think FriCAS should rather use --enable-gmp. With --with-gmp I > would expect to be able to say something like > --with-gmp=/path/to/package/gmp. > Well, you should be able to say where to find GMP. Quite possible that we will need to split '--with-gmp' into '--enable-gmp' and '--with-gmp-library' and '--with-gmp-headers'. ATM the idea is to get _some_ way to use GMP and figure out later which options are useful. > In fact, thinking about this, maybe it should also be > > --enable-algebra-optimization=... > > because according to > > http://www.gnu.org/software/autoconf/manual/html_node/External-Software.html#External-Software > > it is --with-PACKAGENAME, but algebra-optimization is certainly not a > package. > > Optimization is a compile-time feature. > http://www.gnu.org/software/autoconf/manual/html_node/Package-Options.html#Package-Options > > Same with --enable-gmp. It is a feature which optimizes, but is not > really necessary. > You are right. However, GNU coding standards have rather rigid view on some issues and real life is more fuzzy. Hence some confusion which of 'enable' or 'with' to use. Note the following: These options allow users to choose which optional features to build and install. --enable-feature options should never make a feature behave differently or cause one feature to replace another. They should only cause parts of the program to be built rather than left out. Algebra optimization definitely does not work as "parts of the program to be built rather than left out" -- it changes behaviour. Also, at build time '--with-gmp' causes extra code to be built, but at run-time it causes replacement of sbcl routines by GMP ones. BTW: I think it is not the first time where our usage does not fit GNU standards... -- Waldek Hebisch [email protected] -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/fricas-devel?hl=en.
