There is this gentoo bug: https://bugs.gentoo.org/728048

The CFLAGS/LDFLAGS flags are not propagated properly in Makefiles.

I think the attached patch fixes this.

Further more, shall we remove CCF and LDF?  (Instead, we give
CFLAGS/LDFLAGS a default setting.)

- Qian

--
You received this message because you are subscribed to the Google Groups "FriCAS - 
computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/fricas-devel/09c1e662-8633-4f12-8dd9-0e0f4e1b0c6a%40gmail.com.
diff --git a/src/clef/Makefile.in b/src/clef/Makefile.in
index 7693a20a..74c0f8a7 100644
--- a/src/clef/Makefile.in
+++ b/src/clef/Makefile.in
@@ -31,11 +31,11 @@ stamp: $(fricas_target_bindir)/clef$(EXEEXT) \
 	$(STAMP) stamp
 
 $(fricas_target_bindir)/clef$(EXEEXT): $(clef_objects) $(clef_DEPENDENCIES)
-	${CC} -Wall $(clef_objects) $(clef_LDADD) ${LDF} -o $@
+	${CC} -Wall $(clef_objects) $(clef_LDADD) ${LDF} ${LDFLAGS} -o $@
 
 $(fricas_target_libdir)/spadbuf$(EXEEXT): $(spadbuf_objects) \
            $(spadbuf_DEPENDENCIES)
-	${CC} -Wall $(spadbuf_objects) $(spadbuf_LDADD) ${LDF} -o $@
+	${CC} -Wall $(spadbuf_objects) $(spadbuf_LDADD) ${LDF} ${LDFLAGS} -o $@
 
 .PRECIOUS: %.$(OBJEXT)
 
@@ -44,7 +44,7 @@ $(fricas_target_libdir)/spadbuf$(EXEEXT): $(spadbuf_objects) \
 %.$(OBJEXT): ${INC}/edible.h $(fricas_c_macros)
 
 %.$(OBJEXT): $(srcdir)/%.c
-	${CC} -c ${CCF} $(fricas_includes) -o $@ $<
+	${CC} -c ${CCF} ${CFLAGS} $(fricas_includes) -o $@ $<
 
 mostlyclean-local:
 	-rm -f $(clef_objects) $(spadbuf_objects)
diff --git a/src/graph/view2D/Makefile.in b/src/graph/view2D/Makefile.in
index f55f5d2d..995dfece 100644
--- a/src/graph/view2D/Makefile.in
+++ b/src/graph/view2D/Makefile.in
@@ -42,7 +42,7 @@ stamp: $(fricas_target_libdir)/view2D$(EXEEXT)
 
 $(fricas_target_libdir)/view2D$(EXEEXT): $(view2D_objects) $(view2D_DEPENDENCIES)
 	${CC} $(view2D_objects) $(Gfun_objects) -o $@ \
-	    $(view2D_LDADD) $(FRICAS_X11_LDFLAGS) -lm
+	    $(view2D_LDADD) $(FRICAS_X11_LDFLAGS) $(LDFLAGS) -lm
 
 .PRECIOUS: %.$(OBJEXT)
 
diff --git a/src/graph/view3D/Makefile.in b/src/graph/view3D/Makefile.in
index c973c623..951a02f6 100644
--- a/src/graph/view3D/Makefile.in
+++ b/src/graph/view3D/Makefile.in
@@ -51,7 +51,7 @@ stamp: $(fricas_target_libdir)/view3D$(EXEEXT)
 
 $(fricas_target_libdir)/view3D$(EXEEXT): $(view3D_objects) $(view3D_DEPENDENCIES)
 	${CC} $(view3D_objects) $(Gfun_objects) -o $@ \
-		$(view3D_LDADD) $(FRICAS_X11_LDFLAGS) -lm
+		$(view3D_LDADD) $(FRICAS_X11_LDFLAGS) $(LDFLAGS) -lm
 
 .PRECIOUS: %.$(OBJEXT)
 
diff --git a/src/graph/viewAlone/Makefile.in b/src/graph/viewAlone/Makefile.in
index e2bffca1..2bc9c26d 100644
--- a/src/graph/viewAlone/Makefile.in
+++ b/src/graph/viewAlone/Makefile.in
@@ -37,7 +37,7 @@ stamp: $(fricas_target_bindir)/viewAlone$(EXEEXT)
 $(fricas_target_bindir)/viewAlone$(EXEEXT): $(viewAlone_objects) \
 		 $(viewAlone_DEPENDENCIES)
 	${CC} $(viewAlone_objects) -o $@ $(viewAlone_LDADD) \
-		$(FRICAS_X11_LDFLAGS)
+		$(FRICAS_X11_LDFLAGS) $(LDFLAGS)
 
 .PRECIOUS: %.$(OBJEXT)
 
diff --git a/src/graph/viewman/Makefile.in b/src/graph/viewman/Makefile.in
index 3696d8dd..0f34c549 100644
--- a/src/graph/viewman/Makefile.in
+++ b/src/graph/viewman/Makefile.in
@@ -48,7 +48,7 @@ stamp: $(fricas_target_libdir)/viewman$(EXEEXT)
 
 $(fricas_target_libdir)/viewman$(EXEEXT): $(viewman_objects) $(viewman_DEPENDENCIES)
 	${CC} $(viewman_objects) -o $@ $(viewman_LDFLAGS) \
-		$(FRICAS_X11_LDFLAGS)
+		$(FRICAS_X11_LDFLAGS) $(LDFLAGS)
 
 mostlyclean-local:
 	-rm -f $(viewman_objects)
diff --git a/src/hyper/Makefile.in b/src/hyper/Makefile.in
index 118848cb..66a4891c 100644
--- a/src/hyper/Makefile.in
+++ b/src/hyper/Makefile.in
@@ -94,16 +94,19 @@ ${OUTLIB}/presea: $(srcdir)/presea.in
 	chmod a+x $@
 
 ${OUTLIB}/ex2ht$(EXEEXT): $(ex2ht_objects) $(ex2ht_DEPENDENCIES)
-	${CC} $(ex2ht_objects) -o $@ $(ex2ht_LDADD) $(FRICAS_X11_LDFLAGS) -lm
+	${CC} $(ex2ht_objects) -o $@ $(ex2ht_LDADD) $(FRICAS_X11_LDFLAGS) \
+	    $(LDFLAGS) -lm
 
 $(fricas_target_bindir)/htadd$(EXEEXT): $(htadd_objects) $(htadd_DEPENDENCIES)
-	${CC} $(htadd_objects) -o $@ $(htadd_LDADD) $(FRICAS_X11_LDFLAGS) -lm
+	${CC} $(htadd_objects) -o $@ $(htadd_LDADD) $(FRICAS_X11_LDFLAGS) \
+	    $(LDFLAGS) -lm
 
 ${OUTLIB}/hthits$(EXEEXT): $(hthits_objects) $(hthits_DEPENDENCIES)
-	${CC} $(hthits_objects) -o $@ $(hthits_LDADD) $(FRICAS_X11_LDFLAGS) -lm
+	${CC} $(hthits_objects) -o $@ $(hthits_LDADD) $(FRICAS_X11_LDFLAGS) \
+	    $(LDFLAGS) -lm
 
 
 $(fricas_target_bindir)/hypertex$(EXEEXT): $(hypertex_objects) $(hypertex_DEPENDENCIES)
-	 ${CC} -g $(hypertex_objects) -o $@ $(hypertex_LDADD) \
-		$(FRICAS_X11_LDFLAGS) -lm
+	${CC} $(hypertex_objects) -o $@ $(hypertex_LDADD) $(FRICAS_X11_LDFLAGS) \
+	    $(LDFLAGS) -lm
 
diff --git a/src/lib/Makefile.in b/src/lib/Makefile.in
index 7be9960d..8fe9278a 100644
--- a/src/lib/Makefile.in
+++ b/src/lib/Makefile.in
@@ -70,17 +70,18 @@ $(LIBSPAD_SO): $(core_objects_32)
 	  $(fricas_c_runtime_extra) -o $@
 else
 $(LIBSPAD_SO): $(core_objects)
-	$(CC) -g $(SOLIB_FLAGS) $(core_objects) $(fricas_c_runtime_extra) -o $@
+	$(CC) -g $(SOLIB_FLAGS) $(core_objects) $(fricas_c_runtime_extra) \
+	    $(LDFLAGS) -o $@
 
 $(GMP_WRAP_SO): $(srcdir)/gmp_wrap.c
-	$(CC) $(GMP_CPPFLAGS) -g -fPIC $(GMP_LDFLAGS) $(SOLIB_FLAGS) $< \
-	  $(GMP_LIB) -o $@
+	$(CC) $(CFLAGS) $(GMP_CPPFLAGS) -g -fPIC $(GMP_LDFLAGS) $(SOLIB_FLAGS) $< \
+	    $(LDFLAGS) $(GMP_LIB) -o $@
 endif
 
 .PRECIOUS: %.$(OBJEXT)
 
 %.$(OBJEXT): $(srcdir)/%.c $(fricas_c_macros_h)
-	$(CC) -g -fPIC $(CCF) -c $(fricas_includes) \
+	$(CC) -g -fPIC $(CCF) $(CFLAGS) -c $(fricas_includes) \
 	  $(FRICAS_X11_CFLAGS) $< -o $@
 
 # This is a support library, so it does not change often and
diff --git a/src/sman/Makefile.in b/src/sman/Makefile.in
index 9ed3a98a..e83ad2dd 100644
--- a/src/sman/Makefile.in
+++ b/src/sman/Makefile.in
@@ -44,18 +44,18 @@ stamp:	$(OUTLIB)/session$(EXEEXT) \
 .PRECIOUS: %.$(OBJEXT)
 
 %.$(OBJEXT): $(srcdir)/%.c
-	$(CC) -c ${CCF} $(fricas_includes) -I$(srcdir) -o $@ $<
+	$(CC) -c ${CCF} $(CFLAGS) $(fricas_includes) -I$(srcdir) -o $@ $<
 
 ${OUTLIB}/session$(EXEEXT): $(session_objects) $(session_DEPENDENCIES)
-	$(CC) $(session_objects) $(session_LDADD) ${LDF} -o $@
+	$(CC) $(session_objects) $(session_LDADD) ${LDF} $(LDFLAGS) -o $@
 
 ${OUTLIB}/spadclient$(EXEEXT): $(spadclient_objects) $(spadclient_DEPENDENCIES)
-	$(CC) $(spadclient_objects) $(spadclient_LDADD) ${LDF} -o $@
+	$(CC) $(spadclient_objects) $(spadclient_LDADD) ${LDF} $(LDFLAGS) -o $@
 
 spadclient.$(OBJEXT): $(fricas_configdir)/fricas_c_macros.h
 
 ${OUT}/sman$(EXEEXT): $(sman_objects) $(sman_DEPENDENCIES)
-	$(CC) $(sman_objects) $(sman_LDADD) ${LDF} -o $@
+	$(CC) $(sman_objects) $(sman_LDADD) ${LDF} $(LDFLAGS) -o $@
 
 $(sman_objects): $(srcdir)/sman.h $(fricas_c_macros)
 

Reply via email to