On Mon, Sep 02, 2024 at 09:01:39PM +0800, Qian Yun wrote:
>
>
> On 9/2/24 7:56 PM, Waldek Hebisch wrote:
> > On Mon, Sep 02, 2024 at 07:15:12PM +0800, Qian Yun wrote:
> > >
> > >
> > > On 9/2/24 8:13 AM, Waldek Hebisch wrote:
> > > > On Sun, Sep 01, 2024 at 10:32:39AM +0800, Qian Yun wrote:
> > > > > There is this gentoo bug: https://bugs.gentoo.org/728048
> > > > >
> > > > > The CFLAGS/LDFLAGS flags are not propagated properly in Makefiles.
> > > > >
> > > > > I think the attached patch fixes this.
> > > >
> > > > It looks OK assuming that we want behaviour that you implemented.
> > > > However, it is not 100% clear what CFLAGS/LDFLAGS should do.
> > > > For example, in principle for correct configuration we should
> > > > use the same flags both during configure and build. So arguably
> > > > CFLAGS should be propagated from configure to makefiles.
> > > >
> > >
> > > If you export CFLAGS in environment variables, it is already picked
> > > up by configure automatically.
> >
> > I mean that some folks expect CFLAGS given to configure to propagate
> > to Makefiles. For that we would need
> >
> > AC_SUBST(CFLAGS)
>
> https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Preset-Output-Variables.html
>
> I think CFLAGS and LDFLAGS are predefined so AC_SUBST is not needed.
>
> > in 'configure.ac' and something like
> >
> > CFLAGS=@CFLAGS@
> >
> > in relevant Makefiles (or better 'var_def.mk').
> >
>
> CFLAGS is already in 'var_def.mk', so only LDFLAGS is missing there.
Yes, it looks so.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/ZtdprvbABU3sa5uQ%40fricas.org.
