Ok, so what's the reason of "-1" - is it because of non-working code or CI issue?
On Mon, Apr 7, 2014 at 2:31 PM, Anastasia Urlapova <[email protected]>wrote: > Mike, > as I see, only two reviews with "-1" > https://review.openstack.org/#/c/85111 > https://review.openstack.org/#/c/85112 > > others are just in progress|confirmed. > > > On Mon, Apr 7, 2014 at 1:20 PM, Mike Scherbakov > <[email protected]>wrote: > >> Thanks Dmitry. >> >> Ananstasia, is it something we know about and fixing? Do we have bug >> report for it? >> >> We need to fix this ASAP. It's critical for releasing maintenance build. >> >> >> On Mon, Apr 7, 2014 at 2:41 AM, Dmitry Borodaenko < >> [email protected]> wrote: >> >>> Last I checked, a bunch of reviews targeted for stable/4.1 were stuck >>> due to a CI problem, once that is cleared they will need to be rebased and >>> merged. There's a list in my daily syncup report from Friday. >>> On Apr 6, 2014 11:29 AM, "Mike Scherbakov" <[email protected]> >>> wrote: >>> >>>> Thanks folks. >>>> Anything else we want to merge / backport? I'm expecting to have 4.1A >>>> no later than Tuesday... >>>> >>>> >>>> On Thu, Apr 3, 2014 at 8:44 PM, Dmitry Borodaenko < >>>> [email protected]> wrote: >>>> >>>>> Well spotted, same change resubmitted with the original Change-Id >>>>> here: https://review.openstack.org/85105 >>>>> >>>>> On Thu, Apr 3, 2014 at 1:49 AM, Evgeniy L <[email protected]> wrote: >>>>> > Hi Dmitry, >>>>> > >>>>> > This patches are same but they have different Change-Id: >>>>> > >>>>> > https://review.openstack.org/#/c/84203/ >>>>> > https://review.openstack.org/#/c/80689/ >>>>> > >>>>> > I thought we agreed not to change Change-Id when we backport >>>>> patches, am I >>>>> > right? >>>>> > >>>>> > Thanks >>>>> > >>>>> > >>>>> > >>>>> > On Thu, Apr 3, 2014 at 2:27 AM, Dmitry Borodaenko < >>>>> [email protected]> >>>>> > wrote: >>>>> >> >>>>> >> FAO core reviewers: >>>>> >> >>>>> >> https://review.openstack.org/84544 (Subs 1.0.0.0 -> 198.18.1.[1|2] >>>>> in >>>>> >> network checker) -- backport of a fix by Vladimir Kozhukalov, needs >>>>> to >>>>> >> be reviewed (wasn't a trivial rebase) and merged into fuel-main >>>>> >> stable/4.1 >>>>> >> >>>>> >> https://review.openstack.org/84203 (do not create radosgw region >>>>> map >>>>> >> in post-deploy) -- backport of my fix for fuel-astute stable/4.1, >>>>> also >>>>> >> not a trivial rebase, but a very obvious change so should not be a >>>>> >> problem >>>>> >> >>>>> >> https://review.openstack.org/82965 (Set Ceph pg_num dynamically >>>>> based >>>>> >> on fuel_settings) -- proposed for fuel-library master, will need a >>>>> >> backport once merged, fuel-web counterpart is already merged in >>>>> master >>>>> >> and stable/4.1 >>>>> >> >>>>> >> https://review.openstack.org/82629 (Use internal IP for internal >>>>> and >>>>> >> admin RGW endpoints) -- proposed for fuel-library master, will need >>>>> a >>>>> >> backport once merged, no external dependencies >>>>> >> >>>>> >> I'd rather not establish a bad precedent of summarily merging my own >>>>> >> commits, but these fixes are harmless enough and should really land >>>>> in >>>>> >> stable/4.1 by the end of this week. >>>>> >> >>>>> >> Thanks, >>>>> >> >>>>> >> -- >>>>> >> Dmitry Borodaenko >>>>> >> >>>>> >> -- >>>>> >> Mailing list: https://launchpad.net/~fuel-dev >>>>> >> Post to : [email protected] >>>>> >> Unsubscribe : https://launchpad.net/~fuel-dev >>>>> >> More help : https://help.launchpad.net/ListHelp >>>>> > >>>>> > >>>>> >>>>> >>>>> >>>>> -- >>>>> Dmitry Borodaenko >>>>> >>>>> -- >>>>> Mailing list: https://launchpad.net/~fuel-dev >>>>> Post to : [email protected] >>>>> Unsubscribe : https://launchpad.net/~fuel-dev >>>>> More help : https://help.launchpad.net/ListHelp >>>>> >>>> >>>> >>>> >>>> -- >>>> Mike Scherbakov >>>> #mihgen >>>> >>> >> >> >> -- >> Mike Scherbakov >> #mihgen >> > > -- Mike Scherbakov #mihgen
-- Mailing list: https://launchpad.net/~fuel-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~fuel-dev More help : https://help.launchpad.net/ListHelp
