On Mon, Mar 17, 2008 at 01:27:22PM +0100, Jesús Guerrero wrote: > On Fri, 14 Mar 2008 18:27:57 +0100 > Dominik Vogt <[EMAIL PROTECTED]> wrote: > > > On Fri, Mar 14, 2008 at 06:15:36PM +0100, Dominik Vogt wrote: > > > On Wed, Mar 12, 2008 at 01:31:14AM +0100, Jesús Guerrero wrote: > > > > I attach an updated version of the patch, with test cases, docs, > > > > Changelog > > > > and NEWS included. I hope everything is correct. If not, just let me > > > > know. > > > > > > I'll apply the patch ... > > > > But there is a bug. It I specify > > > > menustyle * verticalmargins 50 50, borderwidth 50 50, verticalitemspacing > > 50 50 > > > > I end up with menus that are taller than the screen. It seems > > that the verticalmargins are not taken into account when fvwm > > calculates when to add a continuation menu (More...). > > I forgot to add the margins into the calculations to see how the menu fit > on the height of the screen. As far as I know, there are two of these checks, > one just to check that, and another to see if there's a need to discard one > more item on the current column. > > I attach a fix, I hope it's all fine now.
Actually this patch has more problems which eventually lead to an infinite loop in some cases. I had to make a larger patch that fixed some problems in the size calculation of the "More ..." entry. It works with my latest commit. Ciao Dominik ^_^ ^_^ -- Dominik Vogt
