On Wed, Mar 12, 2008 at 01:31:14AM +0100, Jesús Guerrero wrote:
> I attach an updated version of the patch, with test cases, docs, Changelog
> and NEWS included. I hope everything is correct. If not, just let me know.
I'll apply the patch with some small changes in the comments and
documentation:
> + if (GetIntegerArguments(args, NULL, val, 2) != 2 ||
> + val[0] < 0 || val[0] > MAX_MENU_MARGIN ||
> + val[1] < 0 || val[1] > MAX_MENU_MARGIN)
> + {
> + /* illegal or missing parameters, return to default */
I've replaced "illegal" with "invalid".
> the given arguments are invalid, the built-in defaults are used:
> one pixel above the item or title and two below.</para>
>
> <para>
> +<fvwmopt cmd="MenuStyle" opt="VerticalMargins"/>
> +can be used to add some padding on the top and bottom borders of
> +the menus. It takes two numeric arguments that must be positive
> +integers. If the number of arguments or its values are incorrect,
> +fvwm defaults both to 0, which means no padding at all. If the
> +values are correct, the first one is used for the top margin, and
> +the second one is used for the bottom margin.</para>
I've rephrased this paragraph very slightly.
> diff -r -U5 fvwm/tests/menus/README fvwm/tests/menus/README
> --- fvwm/tests/menus/README 2001-01-21 14:40:17.000000000 +0100
> +++ fvwm/tests/menus/README 2008-03-12 00:27:16.000000000 +0100
> @@ -21,10 +21,11 @@
> SideColor
> SeparatorsLong / SeparatorsShort
> TitleUnderlines0 / TitleUnderlines1 / TitleUnderlines2
> VerticalItemSpacing
> VerticalTitleSpacing
> + VerticalMargins
I've replaced the two tabs with four spaces. (The fvwm source
code is mostly indented by tabs at the width of eight spaces).
> --- fvwm/ChangeLog 2008-03-10 12:16:07.000000000 +0100
> +++ fvwm/ChangeLog 2008-03-12 01:12:03.000000000 +0100
> @@ -1,3 +1,38 @@
> +2008-03-12 Jes??s Guerrero <i92guboj(at)terra(dot)es>
> +
> + * fvwm/menus.c (size_menu_vertically):
> + added paddings at the top and bottom of the menus
...
> +
> + *doc/commands/MenuStyle.xml:
> + *tests/menus/menus.read:
> + *tests/menus/README:
> + *tests/purify/purify.fvwm2rc:
> + documentation and test stuff for VerticalMargins
> +
Note that there are multiple ChangeLog files. If you change
something, in directory fvwm/x/y, you should look for a ChangeLog
file in y first, then in x and finally in fvwm and use that. If
you press "ctrl-x 4 a" in emacs, it looks for the proper file and
adds an entry to it for you.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
