2009/10/21 Thomas Adam <[email protected]>: > On Wed, Oct 21, 2009 at 02:37:54PM +0200, Peter Breitenlohner wrote: >> Hi, >> >> I'd like to propose the attached eight patches for fvwm-2.5.28, mostly >> concerned with the build system but not exclusively so. Each patch starts >> with a comment explaining the purpose, a summay is given below. > > Please resend all of these as separate emails threads in their own right.
Couple of things I've noticed (in no particular order): 1. To make my life (and anyone else who also happens to review these) easier, please actually *read*: docs/DEVELOPERS ... before you submit anymore patches. In fact, I'm going to ask you *again* to read this file, and then redistribute your patches (you had the right idea in terms of subject names in your emails; thanks -- just make them "v2" this time.) You're missing changes to a number of files as a result of not having read this. 2. Why are you patching this against FVWM 2.5.28? Use CVS. 3. I'd like to see your patches inlined in your emails and not as attachments, providing you can turn off "text=flowed", since this makes reviewing much easier. 4. The original eight separate emails you sent out didn't have any text to describe the patch; instead it was embedded at the top of the patch. Don't do this, use that explanatory text as part of the body of your email. -- Thomas Adam
