On Thu, 22 Oct 2009, Thomas Adam wrote:
1. To make my life (and anyone else who also happens to review these)
easier, please actually *read*:
docs/DEVELOPERS
... before you submit anymore patches. In fact, I'm going to ask you
*again* to read this file, .......
Hi Thomas,
done.
....... and then redistribute your patches (you had
the right idea in terms of subject names in your emails; thanks --
just make them "v2" this time.) ...
will do, but that may take a few days.
... You're missing changes to a number of
files as a result of not having read this.
I certainly missed the ChangeLog entries. Is there more?
2. Why are you patching this against FVWM 2.5.28? Use CVS.
two reasons: (1) I had to rebuild 2.5.28 for our systems (replacing 2.4.20)
to get rid of the emacs-23.1 problems with the funny initial window resizing.
(2) I work a lot at home on my notbook without network access.
I have, however, just fetched the CVS.
3. I'd like to see your patches inlined in your emails and not as
attachments, providing you can turn off "text=flowed", since this
makes reviewing much easier.
will do. I suppose pine (alpine-2.00) does this right.
4. The original eight separate emails you sent out didn't have any
text to describe the patch; instead it was embedded at the top of the
patch. Don't do this, use that explanatory text as part of the body
of your email.
will do.
Regards
Peter Breitenlohner <[email protected]>
