2011/5/3 Jesús J. Guerrero Botella <[email protected]>: > El día 28 de abril de 2011 17:14, Jesús J. Guerrero Botella > <[email protected]> escribió: >> El día 28 de abril de 2011 17:00, Thomas Adam <[email protected]> escribió: >>> >>> So I'll let this patch float around for a bit. If you could give it >>> some more testing though, with different FvwmButtons configurations, I'd >>> appreciate that. >> >> Of course. Thanks again. > > Today I found out of pure luck that FvwmButtons segfaults on every > restart. It doesn't seem to have any ill effect though. I just saw the > message in dmesg. > > [ 3257.510088] FvwmButtons[3112]: segfault at 60 ip 000000000040f2ae > sp 00007fffce015b60 error 4 in FvwmButtons[400000+4a000] > [ 3308.771910] FvwmButtons[3613]: segfault at 60 ip 000000000040f2ae > sp 00007ffff929de00 error 4 in FvwmButtons[400000+4a000] > [ 3331.922355] FvwmButtons[3629]: segfault at 60 ip 000000000040f2ae > sp 00007fff57e15610 error 4 in FvwmButtons[400000+4a000] > [ 3358.966625] FvwmButtons[3645]: segfault at 60 ip 000000000040f2ae > sp 00007ffff4c45810 error 4 in FvwmButtons[400000+4a000] > [...] > [ 5641.056207] FvwmButtons[21161]: segfault at 60 ip 000000000040f2ae > sp 00007fffc28b5060 error 4 in FvwmButtons[400000+4a000] > > So, I recompiled without your patch and it doesn't segfault. I attach > a core file in case it's useful to you. > > I tried it with a minimal config for fvwmbuttons, like this: > > DestroyModuleConfig Panel: * > *Panel: Geometry 1656x32+12-12 > *Panel: Columns 1 > *Panel: Rows 1 > *Panel: (1x1) > Module FvwmButtons Panel > > And it segfaults always on restart when fvwm is built with your patch. > It seems that fvwmbuttons crashes when fvwm dies, but it's restarted > without any problem so I don't perceive any ill effect.
Yeah, that's already fixed my end. It was me being silly. OK. I'll commit something similar to my patch when I am back from work. -- Thomas Adam
