Just noticed some random things about code
1) Some returns at the end of void functions have been removed.
These are actually there to improve code quality: I _always_ put
a return at the end of a function. That way, when I come across
a function that I've written that does not have a return at the
end, I know its broken or unfinished.
2) Indentation with tabs everywhere.
Great.
3) Indentation of variables, e.g.:
int x;
int y;
Bool fWasAlreadyPopped = False;
Can this please be reverted? Lining up variable names *always*
leads to bloated patches in the future because lines that have not
been changed need to be reindented if a new variable has a longer
type, and its useless anyway.
4) Indentation of wrapped function declarations.
I don't understand the logic behing this, and I don't have an
xemacs style that could do this properly.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
