On Wed, Sep 10, 2014 at 12:26:09AM +0100, Dominik Vogt wrote: > On Sun, Sep 07, 2014 at 07:23:14AM -0700, Thomas Adam wrote: > > The mvwm repository's new-parser branch has been updated. > > I've just pushed some experimental code to the new branch > dv/new-parser.
Amazing! I've just taken a very quick look and noted that cmdparser.h is missing. https://travis-ci.org/ThomasAdam/mvwm/jobs/34862057 I knew this would come in useful! I suspect you just forgot to "git add" it. > Thomas, you should probably take a look at what I'm doing right > now. As a first step, I have started to replace the parsing code > in __execute_command_line with hook functions defined elsewhere > and stored in a structure. The first milestone is having a parser > that provides the current syntax. Next, I want to carefully clean > up __execute_command_line so that it needs fewer hooks with saner > logic. For now I want to keep compatible, but eventually the hook > structure should be replaced with another one provided by the new > parser. I understand. I've likely got something similar sat here as well, but I'll wait for yours first and mail out suggestions to you, although I don't think you're going to run into many difficulties initially. > One side effect of this first commit is that the static variable > func_depth is eliminated. Instead, I've defined a > cmdparser_context_t that is generated in __execute_command_line > and contains all the state that the cmdparser needs to record. > Eventually, nobody else should look at the contents of the > structure, but at the moment it just contains an (still unused) > copy of the command line and the current nesting depth. Noted, thanks. > This is all work in progress and subject to a lot of refactoring. > Any suggestions are welcome. > > Note: The code is completely untested as I haven't set um mvwm > yet. :-) No worries; see above. I'll take a look at this tomorrow. :) -- Thomas Adam -- "Deep in my heart I wish I was wrong. But deep in my heart I know I am not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
