On Thu, Sep 11, 2014 at 11:44:30PM +0100, Dominik Vogt wrote:
> Another core. fw is a NULL pointer; you use it before checking
> that. Note that WarpToWindow also works on unmanaged windows,
> hence fw may be NULL. WarpToWindow is the only function that needs
> a window but also works on unmanaged windows.
Oops. That's a very good point about unmanaged windows.
> #0 0x080b4544 in CMD_WarpToWindow (cond_rc=0xbfbdd308, exc=0x9e3de08,
> action=0x9e2965d "-20p -20p") at focus.c:1216
> 1216 struct monitor *m = fw->m;
> (gdb) bt
> #0 0x080b4544 in CMD_WarpToWindow (cond_rc=0xbfbdd308, exc=0x9e3de08,
> action=0x9e2965d "-20p -20p") at focus.c:1216
> #1 0x080ac08d in __execute_function (cond_rc=0xbfbdd308, cond_rc@entry=0x20,
> exc=exc@entry=0x0, action=0x9e29650 "WarpToWindow -20p -20p",
> action@entry=0x0, exec_flags=32 ' ', args=0x0, has_ref_window_moved=0)
> at functions.c:643
>
> I'll push a partial fix for this shortly, but you should take a
> look at it and implement the missing bit.
Okey dokey, will do. Thanks.
> I guess we need some plan how to test this new code systematically.
Are you thinking of some kind of test harness for this, or something
less involved?
-- Thomas Adam
--
"Deep in my heart I wish I was wrong. But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
