On Fri, Sep 12, 2014 at 12:19:04AM +0100, Dominik Vogt wrote:
> On Fri, Sep 12, 2014 at 12:03:13AM +0100, Thomas Adam wrote:
> > On Thu, Sep 11, 2014 at 11:44:30PM +0100, Dominik Vogt wrote:
> > > I'll push a partial fix for this shortly, but you should take a
> > > look at it and implement the missing bit.
> >
> > Would you mind testing the following? Thie seems to work OK for me, but
> > just want to check:
>
> At the moment I don't know how to reproduce it, but the patch
> looks good. Since I'm not using unmanages windows I suspect that
> fw *and* exc->w.w were unset. I'm not sure why WarpToWindow was
> called at all in that situation, but if exc->w.w is none,
> XgetGeometry will now fail and exit the function.
>
> The crash was triggered by my Alt-Down binding:
>
> --
> AddToFunc RaiseAndWarp
> + I Focus
> + I Raise
> + I WarpToWindow 95 $[cw.height]p
>
> AddToFunc DirectionOrThis
> + I Direction $0 (!Iconic, CurrentPage) RaiseAndWarp
> + I TestRc (nomatch) ThisWindow (!Iconic, CurrentPage) RaiseAndWarp
>
> Key Down A M DirectionOrThis South
> --
>
> So this somehow managed to call WarpToWindow without a context
> window. I'll look into this.
>
> I've pushed your patch and another one to git.
Ah. Yes. That was it. Before our fixes this crashes mvwm. After the
fixes they don't, and I'm still able to warp to unmanaged windows as
well.
Thanks!
-- Thomas Adam
--
"Deep in my heart I wish I was wrong. But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
