On Sun, Sep 14, 2014 at 10:35:47PM +0100, Dominik Vogt wrote:
> The fix works and looks good. Just two minor things:
>
> * Is there a reason why you use so many blank lines? Personally,
> I'd remove all of them except after the declarations and before
> the return.
No; just my style. Is there any reason why you use so few? :)
> * It's not necessary to fetch the global monitor if it's not used
> later. I'll add a test for this.
I can't say that'd matter much, but OK.
> I've also pushed two more fixes, including another screen related
> crash fix.
Your optimisation to FScreenParseGeometry() might apply to fvwm as well
if you're so inclined; it's the same code/logic.
-- Thomas Adam
--
"Deep in my heart I wish I was wrong. But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
