On Sun, Sep 14, 2014 at 10:58:18PM +0100, Thomas Adam wrote: > On Sun, Sep 14, 2014 at 10:35:47PM +0100, Dominik Vogt wrote: > > The fix works and looks good. Just two minor things: > > > > * Is there a reason why you use so many blank lines? Personally, > > I'd remove all of them except after the declarations and before > > the return. > > No; just my style. Is there any reason why you use so few? :)
Yes, it makes the program shorter and thus easier to read. Once had a colleague who has two or three blank lines before each instruction, and he said that there was so much on the screen already. And the right answer to that is: Use a bigger font. ;-) > > * It's not necessary to fetch the global monitor if it's not used > > later. I'll add a test for this. > > I can't say that'd matter much, but OK. But it doesn't cost anything either except compilation time. > > I've also pushed two more fixes, including another screen related > > crash fix. > > Your optimisation to FScreenParseGeometry() might apply to fvwm as well > if you're so inclined; it's the same code/logic. No, in fvwm you don't have to look up the global screen; it's always just "screens[0]". Ciao Dominik ^_^ ^_^ -- Dominik Vogt
