On Sun, Sep 21, 2014 at 04:56:34PM +0100, Thomas Adam wrote: > > 1) SnapAttraction does not work > > Apologies for the delay on this. This should be fixed now. It was a > complete oversight on my part. I wasn't using the global screen when > performing the calculations, and also made a few typos when converting > over monitor dimensions with respect to the snap calculations. > > This seems to be working fine for me, but do please test it when you > get a few moments.
Works in a very short test. But when compiling with make CFLAGS="-g3 -O3 -Wall -Wpointer-arith -fno-strict-aliasing -Werror" I not get loads of warnings from libs/FScreen.c that are not in fvwm. Did you change anything there recently? Looks like calling FScreenGetScrRect() no longer makes gcc think the pointer arguments are initialised. -- FScreen.c: In function 'FScreenTranslateCoordinates': FScreen.c:439:19: error: 'y_dest' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:435:19: error: 'x_dest' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:439:11: error: 'y_src' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:435:11: error: 'x_src' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c: In function 'FScreenClipToScreen': FScreen.c:464:18: error: 'sh' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:459:18: error: 'sw' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:464:18: error: 'sy' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:459:18: error: 'sx' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c: In function 'FScreenCenterOnScreen': FScreen.c:504:11: error: 'sh' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:503:12: error: 'sw' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:510:5: error: 'sy' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:509:5: error: 'sx' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c: In function 'FScreenIsRectangleOnScreen': FScreen.c:546:44: error: 'sh' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:545:50: error: 'sw' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:546:44: error: 'sy' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:545:50: error: 'sx' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c: In function 'FScreenGetGeometry': FScreen.c:741:5: error: 'scr_h' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:737:5: error: 'scr_w' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:732:4: error: 'scr_y' may be used uninitialized in this function [-Werror=maybe-uninitialized] FScreen.c:731:4: error: 'scr_x' may be used uninitialized in this function [-Werror=maybe-uninitialized] -- Ciao Dominik ^_^ ^_^ -- Dominik Vogt
